From 8a9d738438077a2f8a5afcbac58931f3d6ce67cc Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Fri, 10 Apr 2026 11:13:14 +0700 Subject: [PATCH] Fix sync loader spinner showing for initializing (non-running) agents Initializing agents were mapped to the "running" bucket in both server and client, causing the SyncedLoader spinner to appear in tabs and sidebar workspace rows when opening an agent for the first time. --- packages/app/src/utils/sidebar-agent-state.test.ts | 4 ++-- packages/app/src/utils/sidebar-agent-state.ts | 2 +- packages/server/src/server/session.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/app/src/utils/sidebar-agent-state.test.ts b/packages/app/src/utils/sidebar-agent-state.test.ts index 74f02eba8b..bd62055c8c 100644 --- a/packages/app/src/utils/sidebar-agent-state.test.ts +++ b/packages/app/src/utils/sidebar-agent-state.test.ts @@ -35,7 +35,7 @@ describe("deriveSidebarStateBucket", () => { ).toBe("attention"); }); - it("treats initializing agents as running", () => { + it("treats initializing agents as done", () => { expect( deriveSidebarStateBucket({ status: "initializing", @@ -43,6 +43,6 @@ describe("deriveSidebarStateBucket", () => { requiresAttention: false, attentionReason: null, }), - ).toBe("running"); + ).toBe("done"); }); }); diff --git a/packages/app/src/utils/sidebar-agent-state.ts b/packages/app/src/utils/sidebar-agent-state.ts index 21f07313a0..d1e77b9ed5 100644 --- a/packages/app/src/utils/sidebar-agent-state.ts +++ b/packages/app/src/utils/sidebar-agent-state.ts @@ -21,7 +21,7 @@ export function deriveSidebarStateBucket(input: { if (input.status === "error" || input.attentionReason === "error") { return "failed"; } - if (input.status === "running" || input.status === "initializing") { + if (input.status === "running") { return "running"; } if (input.requiresAttention) { diff --git a/packages/server/src/server/session.ts b/packages/server/src/server/session.ts index eafa8e6eb4..1c113e7166 100644 --- a/packages/server/src/server/session.ts +++ b/packages/server/src/server/session.ts @@ -5322,7 +5322,7 @@ export class Session { if (agent.status === "error" || agent.attentionReason === "error") { return "failed"; } - if (agent.status === "running" || agent.status === "initializing") { + if (agent.status === "running") { return "running"; } if (agent.requiresAttention) {