From 870e08feee1045c90a47d897a46a26527c5a9f00 Mon Sep 17 00:00:00 2001
From: Mohamed Boudra <boudra.moha@gmail.com>
Date: Sat, 18 Jul 2026 13:39:54 +0000
Subject: [PATCH] refactor(server): remove unused websocket close codes

---
 packages/server/src/server/websocket-server.ts     | 14 ++++----------
 .../server/src/server/websocket/physical-socket.ts |  2 --
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/packages/server/src/server/websocket-server.ts b/packages/server/src/server/websocket-server.ts
index cb251c2ce..21f04118a 100644
--- a/packages/server/src/server/websocket-server.ts
+++ b/packages/server/src/server/websocket-server.ts
@@ -90,8 +90,6 @@ import {
   outboundFrameByteLength,
   physicalSocketHasCapacity,
   sendBoundedPhysicalFrame,
-  WS_CLOSE_APPLICATION_LEASE_EXPIRED,
-  WS_CLOSE_OUTBOUND_HIGH_WATER,
 } from "./websocket/physical-socket.js";
 
 const WS_CLOSE_DAEMON_AUTH_FAILED = 4401;
@@ -408,8 +406,6 @@ interface SocketSessionOptions {
 
 interface ClosePhysicalSocketParams {
   ws: WebSocketLike;
-  code: number;
-  reason: string;
   logMessage: string;
   logFields?: Record<string, unknown>;
 }
@@ -745,8 +741,6 @@ export class VoiceAssistantWebSocketServer {
       for (const ws of this.applicationSocketLease.listExpired()) {
         this.closePhysicalSocket({
           ws,
-          code: WS_CLOSE_APPLICATION_LEASE_EXPIRED,
-          reason: "Application heartbeat expired",
           logMessage: "Closing physical WebSocket with expired application lease",
         });
       }
@@ -1065,8 +1059,6 @@ export class VoiceAssistantWebSocketServer {
   private closeAtOutboundHighWater(ws: WebSocketLike): void {
     this.closePhysicalSocket({
       ws,
-      code: WS_CLOSE_OUTBOUND_HIGH_WATER,
-      reason: "Outbound buffer limit exceeded",
       logMessage: "Closing physical WebSocket at outbound high-water mark",
       logFields: {
         bufferedAmount: ws.bufferedAmount,
@@ -1076,7 +1068,7 @@ export class VoiceAssistantWebSocketServer {
   }
 
   private closePhysicalSocket(params: ClosePhysicalSocketParams): void {
-    const { ws, code, reason, logMessage, logFields } = params;
+    const { ws, logMessage, logFields } = params;
     this.applicationSocketLease.release(ws);
     if (ws.readyState !== 1) {
       return;
@@ -1090,10 +1082,12 @@ export class VoiceAssistantWebSocketServer {
       logMessage,
     );
     try {
+      // A close frame queues behind application data, so it cannot enforce a
+      // hard memory cutoff. Production transports expose terminate().
       if (ws.terminate) {
         ws.terminate();
       } else {
-        ws.close(code, reason);
+        ws.close();
       }
     } catch (err) {
       this.logger.warn(
diff --git a/packages/server/src/server/websocket/physical-socket.ts b/packages/server/src/server/websocket/physical-socket.ts
index f42b6fd13..eed29ae35 100644
--- a/packages/server/src/server/websocket/physical-socket.ts
+++ b/packages/server/src/server/websocket/physical-socket.ts
@@ -5,8 +5,6 @@ export const MAX_PHYSICAL_SOCKET_BUFFERED_BYTES = 8 * 1024 * 1024;
 // lease without making an abandoned application socket linger for minutes.
 export const APPLICATION_SOCKET_LEASE_MS = 45_000;
 export const APPLICATION_SOCKET_LEASE_CHECK_INTERVAL_MS = 10_000;
-export const WS_CLOSE_OUTBOUND_HIGH_WATER = 4004;
-export const WS_CLOSE_APPLICATION_LEASE_EXPIRED = 4005;
 
 type Clock = () => number;