From 731c570b256222521516d8a4c59ce5f1a0659172 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Thu, 23 Apr 2026 21:55:19 +0700 Subject: [PATCH] fix(types): repair typecheck after oxlint safe autofix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The safe --fix introduced three type issues: 1. unicorn/prefer-set-has rewrote array literals to `new Set(...)` without updating the `T[]` type annotation — broken assignment. Fix type to `Set` in logger.ts and agent-manager.ts. 2. unicorn/no-array-reverse changed `.reverse()` → `.toReversed()` (ES2023). Bump `lib` to ES2023 in tsconfig.base.json and tsconfig.server.json. Target stays at ES2020 — Node 20 supports the methods natively, no downlevel needed. 3. preserve-caught-error added `new Error(msg, { cause })` (ES2022), also covered by the lib bump. --- packages/server/src/server/agent/agent-manager.ts | 2 +- packages/server/src/server/logger.ts | 2 +- packages/server/tsconfig.server.json | 2 +- tsconfig.base.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/server/src/server/agent/agent-manager.ts b/packages/server/src/server/agent/agent-manager.ts index 214ddcce6..fdb9ac41b 100644 --- a/packages/server/src/server/agent/agent-manager.ts +++ b/packages/server/src/server/agent/agent-manager.ts @@ -278,7 +278,7 @@ type SubscriptionRecord = { agentId: string | null; }; -const BUSY_STATUSES: AgentLifecycleStatus[] = new Set(["initializing", "running"]); +const BUSY_STATUSES: Set = new Set(["initializing", "running"]); const AgentIdSchema = z.string().uuid(); function isAgentBusy(status: AgentLifecycleStatus): boolean { diff --git a/packages/server/src/server/logger.ts b/packages/server/src/server/logger.ts index 76f85efd3..36c95376c 100644 --- a/packages/server/src/server/logger.ts +++ b/packages/server/src/server/logger.ts @@ -37,7 +37,7 @@ type ResolveLogConfigOptions = { env?: NodeJS.ProcessEnv; }; -const LOG_LEVELS: LogLevel[] = new Set(["trace", "debug", "info", "warn", "error", "fatal"]); +const LOG_LEVELS: Set = new Set(["trace", "debug", "info", "warn", "error", "fatal"]); const LOG_FORMATS: LogFormat[] = ["pretty", "json"]; const LOG_LEVEL_PRIORITIES: Record = { trace: 10, diff --git a/packages/server/tsconfig.server.json b/packages/server/tsconfig.server.json index c846e8484..eca3cd0da 100644 --- a/packages/server/tsconfig.server.json +++ b/packages/server/tsconfig.server.json @@ -3,7 +3,7 @@ "target": "ES2020", "module": "NodeNext", "moduleResolution": "NodeNext", - "lib": ["ES2020", "DOM"], + "lib": ["ES2023", "DOM"], "baseUrl": "./src", "paths": { "@server/*": ["./*"] diff --git a/tsconfig.base.json b/tsconfig.base.json index fe84a6012..6c68b1ccd 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -1,7 +1,7 @@ { "compilerOptions": { "target": "ES2020", - "lib": ["ES2020"], + "lib": ["ES2023"], "module": "ESNext", "moduleResolution": "bundler", "strict": true,