fix(app): show branch loading and fetch errors (#8938)

* fix(app): distinguish branch loading from empty results

Preserve branch query pending and error states through the switcher so first open does not report missing branches before the response. Show request failures with a retry action.

* fix(app): keep branch retry progress and keyboard focus

Verify failed cached refresh and keyboard retry through the real browser and daemon. Keep focus in the footer while Retry is disabled so repeated Enter cannot select a cached branch.

* fix(app): preserve picker interaction when retrying branch loads

Use the existing close-and-reopen retry behavior with clear feedback rather than introducing an action that competes with native list keyboard ownership.
This commit is contained in:
Mohamed Boudra
2026-11-06 21:35:20 +07:00
committed by GitHub
parent 471db4bdb5
commit 616f5e155c
12 changed files with 140 additions and 3 deletions
@@ -41,7 +41,15 @@ export function BranchSwitcher({
const toast = useToast();
const queryClient = useQueryClient();
const { branchOptions, isOpen, setIsOpen, handleBranchSelect } = useBranchSwitcher({
const {
branchOptions,
isLoadingBranches,
isFetchingBranches,
branchError,
isOpen,
setIsOpen,
handleBranchSelect,
} = useBranchSwitcher({
client,
normalizedServerId: serverId,
normalizedWorkspaceId: workspaceId,
@@ -73,6 +81,22 @@ export function BranchSwitcher({
[branchLeadingSlot],
);
let emptyText = t("branchSwitcher.empty");
if (isLoadingBranches) emptyText = t("common.states.loading");
else if (branchError) emptyText = "";
const errorFooter = useMemo(
() =>
branchError ? (
<View style={styles.footer}>
<Text accessibilityRole="alert" style={styles.error}>
{isFetchingBranches ? t("common.states.loading") : t("branchSwitcher.failedToLoad")}
</Text>
</View>
) : undefined,
[branchError, isFetchingBranches, t],
);
if (!currentBranchName) {
return null;
}
@@ -85,6 +109,7 @@ export function BranchSwitcher({
testID={testID}
label={currentBranchName}
open={isOpen}
disabled={!isConnected}
onPress={handleOpen}
accessibilityRole="button"
accessibilityLabel={t("branchSwitcher.currentBranch", {
@@ -103,7 +128,8 @@ export function BranchSwitcher({
searchable
placeholder={t("branchSwitcher.placeholder")}
searchPlaceholder={t("branchSwitcher.searchPlaceholder")}
emptyText={t("branchSwitcher.empty")}
emptyText={emptyText}
footer={errorFooter}
title={t("branchSwitcher.title")}
open={isOpen}
onOpenChange={setIsOpen}
@@ -122,6 +148,8 @@ const styles = StyleSheet.create((theme) => ({
flexShrink: 1,
minWidth: 0,
},
footer: { padding: theme.spacing[3], gap: theme.spacing[2] },
error: { color: theme.colors.destructive, fontSize: theme.fontSize.sm },
tooltipText: {
color: theme.colors.popoverForeground,
fontSize: theme.fontSize.sm,