From 5cfe8f1218fe527cc6e4a916ea0287dce703823a Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Wed, 28 Oct 2026 23:30:16 +0700 Subject: [PATCH] Remove the out-of-date daemon sidebar notice (#8133) The notice arrived with the terminal worker change (#7644) but is a separate product change. Remove it with the native/compact callout filtering it needed, restoring the sidebar callout slot to web-only. Restart and close terminals in Settings stays. --- docs/design.md | 2 +- .../browser/daemon-outdated-notice.spec.ts | 69 ------- .../e2e/browser/settings-navigation.spec.ts | 13 +- ...ve-daemon-outdated-notice-preconditions.md | 35 ---- .../native-daemon-outdated-notice.ios.yaml | 26 --- packages/app/src/app/_layout.tsx | 2 - .../daemon-outdated-callout-source.tsx | 182 ---------------- packages/app/src/components/left-sidebar.tsx | 5 +- .../resolve-daemon-outdated-callout.test.ts | 195 ------------------ .../resolve-daemon-outdated-callout.ts | 147 ------------- .../src/components/sidebar-callout-slot.d.ts | 1 + .../sidebar-callout-slot.native.tsx | 3 + .../components/sidebar-callout-slot.test.tsx | 4 +- ...-slot.tsx => sidebar-callout-slot.web.tsx} | 8 +- .../src/contexts/sidebar-callout-context.tsx | 22 +- .../contexts/sidebar-callout-state.test.ts | 24 --- .../app/src/contexts/sidebar-callout-state.ts | 13 +- packages/app/src/i18n/resources/ar.ts | 12 -- packages/app/src/i18n/resources/en.ts | 12 -- packages/app/src/i18n/resources/es.ts | 13 -- packages/app/src/i18n/resources/fr.ts | 13 -- packages/app/src/i18n/resources/ja.ts | 14 -- packages/app/src/i18n/resources/ko.ts | 14 -- packages/app/src/i18n/resources/pt-BR.ts | 13 -- packages/app/src/i18n/resources/ru.ts | 12 -- packages/app/src/i18n/resources/zh-CN.ts | 12 -- 26 files changed, 19 insertions(+), 847 deletions(-) delete mode 100644 packages/app/e2e/browser/daemon-outdated-notice.spec.ts delete mode 100644 packages/app/e2e/mobile/agent-device/native-daemon-outdated-notice-preconditions.md delete mode 100644 packages/app/e2e/mobile/agent-device/native-daemon-outdated-notice.ios.yaml delete mode 100644 packages/app/src/components/daemon-outdated-callout-source.tsx delete mode 100644 packages/app/src/components/resolve-daemon-outdated-callout.test.ts delete mode 100644 packages/app/src/components/resolve-daemon-outdated-callout.ts create mode 100644 packages/app/src/components/sidebar-callout-slot.d.ts create mode 100644 packages/app/src/components/sidebar-callout-slot.native.tsx rename packages/app/src/components/{sidebar-callout-slot.tsx => sidebar-callout-slot.web.tsx} (52%) diff --git a/docs/design.md b/docs/design.md index d115913789..a336b80a64 100644 --- a/docs/design.md +++ b/docs/design.md @@ -203,7 +203,7 @@ Inline errors are a single sentence in `palette.red[300]` `xs`, sitting under th Page-level alerts — informational notices, success confirmations, warnings, or recoverable errors that need a small visible block on the page — use `` (`packages/app/src/components/ui/alert.tsx`). Variants: `default`, `info`, `success`, `warning`, `error`. The chrome is quiet by design: a 1px tinted border, transparent background, a small variant-tinted icon, the title in the variant accent, the description in `foregroundMuted`. Actions go in the `children` slot as `