From 51bbebcdd5ab6166b126be667f8046f1ddd90e40 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Tue, 10 Mar 2026 18:12:09 +0700 Subject: [PATCH] Fix Windows smoke npm invocation --- CHANGELOG.md | 4 ++++ packages/desktop/scripts/managed-daemon-smoke.mjs | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 937d17fb0..6c83f37eb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## 0.1.24 - 2026-03-10 +### Fixed +- Fixed the Windows desktop managed-daemon smoke test to rebuild packaged artifacts without relying on a bare `npm` executable lookup in GitHub Actions. + ## 0.1.23 - 2026-03-10 ### Fixed - Fixed the Windows desktop managed-daemon smoke test to resolve repo paths correctly on GitHub Actions runners. diff --git a/packages/desktop/scripts/managed-daemon-smoke.mjs b/packages/desktop/scripts/managed-daemon-smoke.mjs index 1cacb8bce..c16c084ff 100644 --- a/packages/desktop/scripts/managed-daemon-smoke.mjs +++ b/packages/desktop/scripts/managed-daemon-smoke.mjs @@ -362,8 +362,12 @@ async function ensurePackagedArtifact(binaryPath) { if (process.env.PASEO_MANAGED_SMOKE_SKIP_BUILD === "1") { return; } + const npmExecPath = process.env.npm_execpath; + if (!npmExecPath) { + throw new Error("npm_execpath is required to build the packaged desktop artifact during smoke tests."); + } try { - await execFileAsync("npm", ["run", "build"], { + await execFileAsync(process.execPath, [npmExecPath, "run", "build"], { cwd: desktopRoot, env: process.env, maxBuffer: 20 * 1024 * 1024,