From 1e0a9d5af078c1f8c52cec950ae967d324cc8f90 Mon Sep 17 00:00:00 2001 From: "paseo-bot[bot]" <266920839+paseo-bot[bot]@users.noreply.github.com> Date: Wed, 21 Oct 2026 14:57:22 +0200 Subject: [PATCH] fix(plugins): allow notification timeline transformers (#7582) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: 陈睿 Co-authored-by: Gavin Chen Co-authored-by: paseo-bot[bot] <266920839+paseo-bot[bot]@users.noreply.github.com> --- packages/app/src/plugins/evaluate.test.ts | 6 +++--- packages/app/src/plugins/evaluate.ts | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/app/src/plugins/evaluate.test.ts b/packages/app/src/plugins/evaluate.test.ts index b4062b2376..f0c768139a 100644 --- a/packages/app/src/plugins/evaluate.test.ts +++ b/packages/app/src/plugins/evaluate.test.ts @@ -141,7 +141,7 @@ describe("evaluatePluginClientBundle", () => { Reflect.deleteProperty(globalThis, "__pluginRemovals"); }); - it("collects timeline transformers and renderers", () => { + it.each(["tool_call", "notification"])("collects %s transformers and renderers", (itemType) => { const plugin = evaluatePluginClientBundle( "reports", bundle(` @@ -149,7 +149,7 @@ describe("evaluatePluginClientBundle", () => { const schema = { safeParse(value) { return { success: true, data: value }; } }; plugin.addTimelineTransformer({ id: "test-report", - query: { itemType: "tool_call" }, + query: { itemType: "${itemType}" }, transform() { return { items: [] }; }, }); plugin.addTimelineRenderer({ @@ -162,7 +162,7 @@ describe("evaluatePluginClientBundle", () => { ); expect(plugin.timelineTransformers.map(({ id, query }) => ({ id, query }))).toEqual([ - { id: "test-report", query: { itemType: "tool_call" } }, + { id: "test-report", query: { itemType } }, ]); expect(plugin.timelineRenderers.map(({ kind, version }) => ({ kind, version }))).toEqual([ { kind: "test-report", version: 1 }, diff --git a/packages/app/src/plugins/evaluate.ts b/packages/app/src/plugins/evaluate.ts index 0cc1a7666e..db5fece8c7 100644 --- a/packages/app/src/plugins/evaluate.ts +++ b/packages/app/src/plugins/evaluate.ts @@ -47,6 +47,7 @@ const TIMELINE_ITEM_TYPES = new Set([ "reasoning", "tool_call", "todo", + "notification", "error", "compaction", ]);