From 154a088d6ee007a35db70dcb2c4331f3e8c2d05b Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Sun, 4 Oct 2026 23:04:17 +0100 Subject: [PATCH] feat(app): default sidebar workspace slots to last activity (#6087) --- packages/app/e2e/browser/agent-relative-time.spec.ts | 4 ---- packages/app/e2e/browser/sidebar-title-width.spec.ts | 2 ++ packages/app/src/hooks/use-settings/storage.ts | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/app/e2e/browser/agent-relative-time.spec.ts b/packages/app/e2e/browser/agent-relative-time.spec.ts index 17dae013ec..4fe1efe887 100644 --- a/packages/app/e2e/browser/agent-relative-time.spec.ts +++ b/packages/app/e2e/browser/agent-relative-time.spec.ts @@ -4,7 +4,6 @@ import { getServerId } from "../support/helpers/server-id"; import { seedMockAgentWorkspace } from "../support/helpers/mock-agent"; import { openAgentRoute } from "../support/helpers/mock-agent"; import { resetSeededPageState, openSessions } from "../support/helpers/archive-tab"; -import { closeSidebarDisplayPreferences, openSidebarDisplayPage } from "../support/helpers/sidebar"; test("agent list age advances and command center says just now for a fresh agent", async ({ page, @@ -41,9 +40,6 @@ test("agent list age advances and command center says just now for a fresh agent "3m ago", ); - await openSidebarDisplayPage(page, "sidebar-display-show"); - await page.getByRole("menuitem", { name: "Last activity", exact: true }).click(); - await closeSidebarDisplayPreferences(page); await expect(page.getByTestId("sidebar-workspace-timestamp").first()).toHaveText("3m"); } finally { await session.cleanup(); diff --git a/packages/app/e2e/browser/sidebar-title-width.spec.ts b/packages/app/e2e/browser/sidebar-title-width.spec.ts index 80f96dc68b..77b5a99eb5 100644 --- a/packages/app/e2e/browser/sidebar-title-width.spec.ts +++ b/packages/app/e2e/browser/sidebar-title-width.spec.ts @@ -88,6 +88,7 @@ async function openTouchWorkspaceList(page: Page, testInfo: TestInfo) { await gotoAppShell(page); await openMobileAgentSidebar(page); await expect(workspaceRow(page)).toBeVisible(); + await toggleTrailing(page, "Diff stats", true); await page.mouse.move(0, 0); await page.screenshot({ path: testInfo.outputPath("sidebar.png") }); } @@ -106,6 +107,7 @@ async function openDesktopWorkspaceList(page: Page) { await gotoAppShell(page); const row = workspaceRow(page); await expect(row).toBeVisible(); + await toggleTrailing(page, "Diff stats"); await page.mouse.move(0, 0); await expect(row.getByText("+12.3k", { exact: true })).toBeVisible(); return titleWidth(row); diff --git a/packages/app/src/hooks/use-settings/storage.ts b/packages/app/src/hooks/use-settings/storage.ts index a954074e8b..6c44546668 100644 --- a/packages/app/src/hooks/use-settings/storage.ts +++ b/packages/app/src/hooks/use-settings/storage.ts @@ -150,7 +150,7 @@ export const DEFAULT_CLIENT_SETTINGS: AppSettings = { contentMaxWidth: null, syntaxTheme: "one", workspaceTitleSource: "title", - sidebarWorkspaceTrailing: "diff", + sidebarWorkspaceTrailing: "timestamp", sidebarRowItems: DEFAULT_SIDEBAR_ROW_ITEMS, sidebarChecksDisplay: DEFAULT_SIDEBAR_CHECKS_DISPLAY, sidebarNavItems: [], @@ -242,7 +242,7 @@ const StoredAppSettingsSchema = z .catch(null), syntaxTheme: z.string().refine(isSyntaxThemeId).catch("one"), workspaceTitleSource: z.enum(["title", "branch"]).catch("title"), - sidebarWorkspaceTrailing: z.enum(["diff", "timestamp", "none"]).catch("diff"), + sidebarWorkspaceTrailing: z.enum(["diff", "timestamp", "none"]).catch("timestamp"), sidebarRowItems: SidebarRowItemsSchema, sidebarChecksDisplay: z .enum(["iconAndText", "icon", "none"])