From 0ffac203af36dafec8bb4e0090c4b4d49cbdbe6e Mon Sep 17 00:00:00 2001
From: Mohamed Boudra <boudra.moha@gmail.com>
Date: Mon, 29 Dec 2025 10:28:24 +0700
Subject: [PATCH] Test Codex image attachment temp path

---
 REPORT-codex-image-attachment-test.md | 27 +++++++++++++++++++++++++++
 plan.md                               | 18 ++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 REPORT-codex-image-attachment-test.md

diff --git a/REPORT-codex-image-attachment-test.md b/REPORT-codex-image-attachment-test.md
new file mode 100644
index 000000000..37c589da2
--- /dev/null
+++ b/REPORT-codex-image-attachment-test.md
@@ -0,0 +1,27 @@
+# Codex Image Attachment Test (Playwright MCP)
+
+## Summary
+- Image upload via the new agent screen succeeded and Codex identified the color as red.
+- The Codex prompt still appears to contain base64 image data rather than a temp file path.
+- `/tmp/paseo-attachments` was not created during the request.
+
+## Steps
+1. Opened `http://localhost:8081/agent/new` with Codex selected, working dir set to `/Users/moboudra/dev/voice-dev`.
+2. Clicked the attachment icon in the composer and uploaded `/tmp/red.png`.
+3. Sent message: `what color is this image?`.
+4. Observed agent response and timeline.
+
+## Evidence
+- UI console logs showed image attachments included in create-agent request:
+  - `handleSendMessage - selectedImages: 1`
+  - `createAgent called with images: 1`
+  - `createAgent message has images: true 1`
+- Agent response:
+  - `The image is solid red (#ff0000).`
+- Timeline showed a tool command containing inline base64 data:
+  - `/bin/zsh -lc python - <<'PY' ... b='iVBORw0K...' ...`
+- Temp directory not created:
+  - `ls -la /tmp/paseo-attachments` → `No such file or directory`.
+
+## Implication
+The Codex prompt still includes base64 data (or an equivalent inline payload) rather than referencing a temp file path, so the recent fix to write attachments under `/tmp/paseo-attachments` does not appear to be taking effect.
diff --git a/plan.md b/plan.md
index eb3d51422..2bc1087ee 100644
--- a/plan.md
+++ b/plan.md
@@ -172,3 +172,21 @@ Improvements to the new agent screen in the app.
     - Pass file path in prompt text (e.g., "User attached image: /tmp/paseo-attachments/abc123.png").
     - Codex can then use its Read tool to view the image without bloating context.
     - **Done (2025-12-29 10:12)**: WHAT: `packages/server/src/server/agent/providers/codex-mcp-agent.ts:2314-2363` adds temp file helpers and writes image attachments under `/tmp/paseo-attachments` before emitting prompt text; `packages/server/src/server/agent/providers/codex-mcp-agent.ts:2884` now awaits async prompt building. RESULT: Codex prompts reference temp file paths instead of base64 data URLs, avoiding context bloat. EVIDENCE: Not run (not requested).
+
+- [x] **Test**: Verify Codex image attachment fix via Playwright MCP.
+
+    - Upload a test image to Codex agent and ask "what color is this image?".
+    - Verify Codex correctly identifies the color.
+    - Check server logs or agent timeline to confirm:
+        1. Prompt contains a file path (e.g., `/tmp/paseo-attachments/{uuid}.png`) NOT base64 data.
+        2. Codex accesses the file via Read tool or Bash (e.g., `cat`, Python script with file path).
+    - Verify the temp file exists in `/tmp/paseo-attachments/` during the request.
+    - Confirm no base64 data URL appears in the prompt text sent to Codex MCP.
+    - **Done (2025-02-10 09:26)**: WHAT: `REPORT-codex-image-attachment-test.md:1` documents Playwright MCP results; `plan.md:176` marked this test complete and added a follow-up fix task. RESULT: Codex correctly identified the color but still received base64 in the prompt; `/tmp/paseo-attachments` was not created. EVIDENCE: UI timeline showed a tool command embedding base64 data, response was "The image is solid red (#ff0000).", and `ls -la /tmp/paseo-attachments` returned "No such file or directory"; full details in `REPORT-codex-image-attachment-test.md`.
+
+- [ ] **Fix**: Codex image attachment prompt still embeds base64.
+
+    - Reproduce with a new Codex agent and image attachment from `http://localhost:8081/agent/new`.
+    - Confirm server prompt includes base64 data URL instead of `/tmp/paseo-attachments/{uuid}.png`.
+    - Ensure temp files are created under `/tmp/paseo-attachments` and prompt only references the file path.
+    - Add a lightweight regression test or log assertion if possible.