From 0a3fed0643f482ec4d5fc287f83fa4568120abc8 Mon Sep 17 00:00:00 2001 From: "paseo-bot[bot]" <266920839+paseo-bot[bot]@users.noreply.github.com> Date: Sat, 21 Nov 2026 06:45:56 +0000 Subject: [PATCH] test(server): wait for file observation before atomic replacement (#10372) Co-authored-by: paseo-bot[bot] <266920839+paseo-bot[bot]@users.noreply.github.com> --- packages/server/src/server/file-observer/index.test.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/server/src/server/file-observer/index.test.ts b/packages/server/src/server/file-observer/index.test.ts index 10c4ea9b73..8053a6da2a 100644 --- a/packages/server/src/server/file-observer/index.test.ts +++ b/packages/server/src/server/file-observer/index.test.ts @@ -2,6 +2,7 @@ import { mkdir, mkdtemp, rename, rm, writeFile } from "node:fs/promises"; import { tmpdir } from "node:os"; import { basename, dirname, join, sep } from "node:path"; import { afterEach, expect, test, vi } from "vitest"; +import { createWatcherLivenessCanary } from "../watcher-liveness-canary.js"; import { createFileObserver, type FileChange, @@ -167,12 +168,17 @@ test("survives atomic replacement and remains observable", async () => { const root = await createRoot(); const target = join(root, "target.txt"); await writeFile(target, "before"); + const canary = createWatcherLivenessCanary(root); const events: FileChange[] = []; const subscription = await subscribeToFileChanges(root, (error, batch) => { expect(error).toBeNull(); - events.push(...batch); + events.push(...canary.filterEvents(batch)); }); + // macOS starts delivering native events asynchronously after subscription. + await canary.verify(); + events.length = 0; + const replacement = join(root, "replacement.txt"); await writeFile(replacement, "after"); await rename(replacement, target);