From 0406720d4bec460ba6a33ce78fc11fff7e338702 Mon Sep 17 00:00:00 2001
From: Mohamed Boudra <boudra.moha@gmail.com>
Date: Thu, 25 Dec 2025 20:21:33 +0700
Subject: [PATCH] Add review task: New agent page missing features from old
 modal
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Investigated the new /agent/new page vs old create-agent-modal.tsx:

MISSING FROM NEW PAGE:
1. Git options (branch selection, worktree creation)
2. Dictation/voice input support
3. Image attachment handling
4. Error message display
5. Loading state during creation
6. Daemon availability checks
7. Import flow

ALSO FOUND:
- CreateAgentModal in home-footer.tsx:206-209 is dead code
  (showCreateModal is never set to true)
- Import flow still uses old modal (works correctly)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 plan.md | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/plan.md b/plan.md
index a0ed8a9fd..8aa70b775 100644
--- a/plan.md
+++ b/plan.md
@@ -185,3 +185,33 @@ Build a new Codex MCP provider side‑by‑side with the existing Codex SDK prov
   **RESULT**: Typecheck passes. Persistence E2E test "persists session metadata and resumes with history" passes (8.3s). The test now exercises disk loading since there's no global Map to provide in-memory history. Net change: -12 lines.
 
   **NOTE**: Two flaky tests ("maps thread/item events..." and "captures tool call inputs/outputs...") also failed before this change - they depend on LLM choosing to call MCP tools/web search which is non-deterministic.
+
+- [ ] **REVIEW (App)**: New agent page (`/agent/new`) is missing features from old modal.
+
+  **Context**: A new agent creation flow was added at `packages/app/src/app/agent/new.tsx`. Compared to the old `create-agent-modal.tsx`, it's missing critical functionality:
+
+  **MISSING FEATURES**:
+  1. **Git options section** - The old modal has `GitOptionsSection` with:
+     - Base branch selection dropdown
+     - "Create new branch" toggle + branch name input
+     - "Create worktree" toggle + worktree slug input
+     - Git validation errors display
+     - Dirty working directory warning
+  2. **Dictation support** - Old modal has full `useDictation` integration for voice input
+  3. **Image attachments** - Old modal handles images, new page returns early if images present (line 216-218)
+  4. **Error message display** - Old modal shows `errorMessage` state to user
+  5. **Loading state** - Old modal has `isLoading` state during agent creation
+  6. **Daemon availability error handling** - Old modal checks if daemon is online and shows appropriate errors
+  7. **Import flow** - Old modal supports `flow: "create" | "import"`, new page is create-only
+
+  **FILES**:
+  - `packages/app/src/app/agent/new.tsx` - New page (incomplete)
+  - `packages/app/src/components/create-agent-modal.tsx` - Old modal (complete)
+  - `packages/app/src/components/home-footer.tsx:167` - Routes to `/agent/new`
+
+  **CURRENT STATE**:
+  - "New Agent" button → navigates to `/agent/new` (incomplete new page)
+  - "Import" button → opens `ImportAgentModal` (old modal, still works)
+  - `CreateAgentModal` in `home-footer.tsx:206-209` is **DEAD CODE** - `showCreateModal` is never set to `true`
+
+  **ACTION NEEDED**: Complete the new `/agent/new` page with all missing features, then remove dead `CreateAgentModal` code from home-footer.