puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-11-06 00:14:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): a New workspace item's commands stop working once its project or host is left

Browse Source 
Every item received the same command functions, which act on the current screen state. A lookup
that finished after the user switched projects could still call setBranch or setMetadata and
overwrite the new project's choices; the reset on a switch only clears what was already written.

The setup model now hands out commands per target with commandsFor({ serverId, projectId }).
They reject with a "moved to another project or host" error when the screen is on another target,
like the lock rejects, so the promise only resolves when the change took effect.
This commit is contained in:
Mohamed Boudra
2026-11-05 22:20:09 +01:00
parent 9c5025ad63
commit 03580ce50b
7 changed files with 148 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/plugins.md
+9 -3
View File
@@ -724,9 +724,15 @@ now means another project, because its identity changes every render. The store
and `metadata` on the same change in `syncInputs`, and a remounted item's mount effect sets them
again.
Known limit: an item that issues a command from `useLayoutEffect` on mount runs before the screen's
`syncInputs` layout effect, so it is validated against the previous target's inputs and the reset
can clear what it set. This applies to a project switch as well as a host switch, since items
An item's commands come from `setup.commandsFor({ serverId, projectId })`, bound to the target the
item was mounted for. Once `syncInputs` reports another target they reject with a "moved" error, so
a lookup that finishes after a project switch cannot write into the new project's choices. The
reset only clears what was already written; this check covers what is written later. Rejecting, not
ignoring, matches the lock: a command's promise resolves only when the change took effect.
Known limit: an item that issues a command from `useLayoutEffect` on mount after a project or host
switch runs before the screen's `syncInputs` layout effect, so its commands (bound to the new
target) still see the previous target and reject as moved. This applies to a project switch as well as a host switch, since items
remount per `(serverId, project id)`. Passive effects are not affected.
`ensureWorkspace` sends the store's `branch` as `source.branchName` whenever the worktree cuts a