Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.
app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help
components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
(structurally load-bearing / edge-case-heavy)
config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
`.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts
hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
MeasuredNode interface + one cast site
root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
members
eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
(compiled by react/compiler, deps live in $[N] memo arrays that
eslint can't introspect) and removed the now-orphan in-file
disable directive in ScrollBox.tsx
fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
{ force: true }) — kills the no-empty lint error and is more
idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
two useEffect dep arrays (they're stable React setState setters;
adding is safe and silences exhaustive-deps)
verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
tests/hermes_cli/test_tui_resume_flow.py
tests/hermes_cli/test_tui_npm_install.py → 57/57
236 lines
6.5 KiB
TypeScript
236 lines
6.5 KiB
TypeScript
import { Box, Text, useInput } from '@hermes/ink'
|
|
import { useEffect, useState } from 'react'
|
|
|
|
import type { GatewayClient } from '../gatewayClient.js'
|
|
import type { ModelOptionProvider, ModelOptionsResponse } from '../gatewayTypes.js'
|
|
import { asRpcResult, rpcErrorMessage } from '../lib/rpc.js'
|
|
import type { Theme } from '../theme.js'
|
|
|
|
const VISIBLE = 12
|
|
|
|
const pageOffset = (count: number, sel: number) => Math.max(0, Math.min(sel - Math.floor(VISIBLE / 2), count - VISIBLE))
|
|
|
|
const visibleItems = (items: string[], sel: number) => {
|
|
const off = pageOffset(items.length, sel)
|
|
|
|
return { items: items.slice(off, off + VISIBLE), off }
|
|
}
|
|
|
|
export function ModelPicker({ gw, onCancel, onSelect, sessionId, t }: ModelPickerProps) {
|
|
const [providers, setProviders] = useState<ModelOptionProvider[]>([])
|
|
const [currentModel, setCurrentModel] = useState('')
|
|
const [err, setErr] = useState('')
|
|
const [loading, setLoading] = useState(true)
|
|
const [persistGlobal, setPersistGlobal] = useState(false)
|
|
const [providerIdx, setProviderIdx] = useState(0)
|
|
const [modelIdx, setModelIdx] = useState(0)
|
|
const [stage, setStage] = useState<'model' | 'provider'>('provider')
|
|
|
|
useEffect(() => {
|
|
gw.request<ModelOptionsResponse>('model.options', sessionId ? { session_id: sessionId } : {})
|
|
.then(raw => {
|
|
const r = asRpcResult<ModelOptionsResponse>(raw)
|
|
|
|
if (!r) {
|
|
setErr('invalid response: model.options')
|
|
setLoading(false)
|
|
|
|
return
|
|
}
|
|
|
|
const next = r.providers ?? []
|
|
setProviders(next)
|
|
setCurrentModel(String(r.model ?? ''))
|
|
setProviderIdx(
|
|
Math.max(
|
|
0,
|
|
next.findIndex(p => p.is_current)
|
|
)
|
|
)
|
|
setModelIdx(0)
|
|
setErr('')
|
|
setLoading(false)
|
|
})
|
|
.catch((e: unknown) => {
|
|
setErr(rpcErrorMessage(e))
|
|
setLoading(false)
|
|
})
|
|
}, [gw, sessionId])
|
|
|
|
const provider = providers[providerIdx]
|
|
const models = provider?.models ?? []
|
|
|
|
useInput((ch, key) => {
|
|
if (key.escape) {
|
|
if (stage === 'model') {
|
|
setStage('provider')
|
|
setModelIdx(0)
|
|
|
|
return
|
|
}
|
|
|
|
onCancel()
|
|
|
|
return
|
|
}
|
|
|
|
const count = stage === 'provider' ? providers.length : models.length
|
|
const sel = stage === 'provider' ? providerIdx : modelIdx
|
|
const setSel = stage === 'provider' ? setProviderIdx : setModelIdx
|
|
|
|
if (key.upArrow && sel > 0) {
|
|
setSel(v => v - 1)
|
|
|
|
return
|
|
}
|
|
|
|
if (key.downArrow && sel < count - 1) {
|
|
setSel(v => v + 1)
|
|
|
|
return
|
|
}
|
|
|
|
if (key.return) {
|
|
if (stage === 'provider') {
|
|
if (!provider) {
|
|
return
|
|
}
|
|
|
|
setStage('model')
|
|
setModelIdx(0)
|
|
|
|
return
|
|
}
|
|
|
|
const model = models[modelIdx]
|
|
|
|
if (provider && model) {
|
|
onSelect(`${model} --provider ${provider.slug}${persistGlobal ? ' --global' : ''}`)
|
|
} else {
|
|
setStage('provider')
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
if (ch.toLowerCase() === 'g') {
|
|
setPersistGlobal(v => !v)
|
|
|
|
return
|
|
}
|
|
|
|
const n = ch === '0' ? 10 : parseInt(ch, 10)
|
|
|
|
if (!Number.isNaN(n) && n >= 1 && n <= Math.min(10, count)) {
|
|
const off = pageOffset(count, sel)
|
|
|
|
if (stage === 'provider') {
|
|
const next = off + n - 1
|
|
|
|
if (providers[next]) {
|
|
setProviderIdx(next)
|
|
}
|
|
} else if (provider && models[off + n - 1]) {
|
|
onSelect(`${models[off + n - 1]} --provider ${provider.slug}${persistGlobal ? ' --global' : ''}`)
|
|
}
|
|
}
|
|
})
|
|
|
|
if (loading) {
|
|
return <Text color={t.color.dim}>loading models…</Text>
|
|
}
|
|
|
|
if (err) {
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text color={t.color.label}>error: {err}</Text>
|
|
<Text color={t.color.dim}>Esc to cancel</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
if (!providers.length) {
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text color={t.color.dim}>no authenticated providers</Text>
|
|
<Text color={t.color.dim}>Esc to cancel</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
if (stage === 'provider') {
|
|
const rows = providers.map(
|
|
p => `${p.is_current ? '*' : ' '} ${p.name} · ${p.total_models ?? p.models?.length ?? 0} models`
|
|
)
|
|
|
|
const { items, off } = visibleItems(rows, providerIdx)
|
|
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text bold color={t.color.amber}>
|
|
Select Provider
|
|
</Text>
|
|
|
|
<Text color={t.color.dim}>Current model: {currentModel || '(unknown)'}</Text>
|
|
{provider?.warning ? <Text color={t.color.label}>warning: {provider.warning}</Text> : null}
|
|
{off > 0 && <Text color={t.color.dim}> ↑ {off} more</Text>}
|
|
|
|
{items.map((row, i) => {
|
|
const idx = off + i
|
|
|
|
return (
|
|
<Text color={providerIdx === idx ? t.color.cornsilk : t.color.dim} key={row}>
|
|
{providerIdx === idx ? '▸ ' : ' '}
|
|
{i + 1}. {row}
|
|
</Text>
|
|
)
|
|
})}
|
|
|
|
{off + VISIBLE < rows.length && <Text color={t.color.dim}> ↓ {rows.length - off - VISIBLE} more</Text>}
|
|
<Text color={t.color.dim}>persist: {persistGlobal ? 'global' : 'session'} · g toggle</Text>
|
|
<Text color={t.color.dim}>↑/↓ select · Enter choose · 1-9,0 quick · Esc cancel</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
const { items, off } = visibleItems(models, modelIdx)
|
|
|
|
return (
|
|
<Box flexDirection="column">
|
|
<Text bold color={t.color.amber}>
|
|
Select Model
|
|
</Text>
|
|
|
|
<Text color={t.color.dim}>{provider?.name || '(unknown provider)'}</Text>
|
|
{!models.length ? <Text color={t.color.dim}>no models listed for this provider</Text> : null}
|
|
{provider?.warning ? <Text color={t.color.label}>warning: {provider.warning}</Text> : null}
|
|
{off > 0 && <Text color={t.color.dim}> ↑ {off} more</Text>}
|
|
|
|
{items.map((row, i) => {
|
|
const idx = off + i
|
|
|
|
return (
|
|
<Text color={modelIdx === idx ? t.color.cornsilk : t.color.dim} key={row}>
|
|
{modelIdx === idx ? '▸ ' : ' '}
|
|
{i + 1}. {row}
|
|
</Text>
|
|
)
|
|
})}
|
|
|
|
{off + VISIBLE < models.length && <Text color={t.color.dim}> ↓ {models.length - off - VISIBLE} more</Text>}
|
|
<Text color={t.color.dim}>persist: {persistGlobal ? 'global' : 'session'} · g toggle</Text>
|
|
<Text color={t.color.dim}>
|
|
{models.length ? '↑/↓ select · Enter switch · 1-9,0 quick · Esc back' : 'Enter/Esc back'}
|
|
</Text>
|
|
</Box>
|
|
)
|
|
}
|
|
|
|
interface ModelPickerProps {
|
|
gw: GatewayClient
|
|
onCancel: () => void
|
|
onSelect: (value: string) => void
|
|
sessionId: string | null
|
|
t: Theme
|
|
}
|