Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.
app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help
components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
(structurally load-bearing / edge-case-heavy)
config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
`.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts
hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
MeasuredNode interface + one cast site
root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
members
eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
(compiled by react/compiler, deps live in $[N] memo arrays that
eslint can't introspect) and removed the now-orphan in-file
disable directive in ScrollBox.tsx
fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
{ force: true }) — kills the no-empty lint error and is more
idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
two useEffect dep arrays (they're stable React setState setters;
adding is safe and silences exhaustive-deps)
verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
tests/hermes_cli/test_tui_resume_flow.py
tests/hermes_cli/test_tui_npm_install.py → 57/57
167 lines
4.6 KiB
TypeScript
167 lines
4.6 KiB
TypeScript
import { spawnSync } from 'node:child_process'
|
|
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
|
|
import { useStore } from '@nanostores/react'
|
|
import { useCallback, useMemo, useState } from 'react'
|
|
|
|
import type { PasteEvent } from '../components/textInput.js'
|
|
import { LARGE_PASTE } from '../config/limits.js'
|
|
import { useCompletion } from '../hooks/useCompletion.js'
|
|
import { useInputHistory } from '../hooks/useInputHistory.js'
|
|
import { useQueue } from '../hooks/useQueue.js'
|
|
import { pasteTokenLabel, stripTrailingPasteNewlines } from '../lib/text.js'
|
|
|
|
import type { PasteSnippet, UseComposerStateOptions, UseComposerStateResult } from './interfaces.js'
|
|
import { $isBlocked } from './overlayStore.js'
|
|
|
|
export function useComposerState({ gw, onClipboardPaste, submitRef }: UseComposerStateOptions): UseComposerStateResult {
|
|
const [input, setInput] = useState('')
|
|
const [inputBuf, setInputBuf] = useState<string[]>([])
|
|
const [pasteSnips, setPasteSnips] = useState<PasteSnippet[]>([])
|
|
const isBlocked = useStore($isBlocked)
|
|
|
|
const { queueRef, queueEditRef, queuedDisplay, queueEditIdx, enqueue, dequeue, replaceQ, setQueueEdit, syncQueue } =
|
|
useQueue()
|
|
|
|
const { historyRef, historyIdx, setHistoryIdx, historyDraftRef, pushHistory } = useInputHistory()
|
|
const { completions, compIdx, setCompIdx, compReplace } = useCompletion(input, isBlocked, gw)
|
|
|
|
const clearIn = useCallback(() => {
|
|
setInput('')
|
|
setInputBuf([])
|
|
setQueueEdit(null)
|
|
setHistoryIdx(null)
|
|
historyDraftRef.current = ''
|
|
}, [historyDraftRef, setQueueEdit, setHistoryIdx])
|
|
|
|
const handleTextPaste = useCallback(
|
|
({ bracketed, cursor, hotkey, text, value }: PasteEvent) => {
|
|
if (hotkey) {
|
|
void onClipboardPaste(false)
|
|
|
|
return null
|
|
}
|
|
|
|
const cleanedText = stripTrailingPasteNewlines(text)
|
|
|
|
if (!cleanedText || !/[^\n]/.test(cleanedText)) {
|
|
if (bracketed) {
|
|
void onClipboardPaste(true)
|
|
}
|
|
|
|
return null
|
|
}
|
|
|
|
const lineCount = cleanedText.split('\n').length
|
|
|
|
if (cleanedText.length < LARGE_PASTE.chars && lineCount < LARGE_PASTE.lines) {
|
|
return {
|
|
cursor: cursor + cleanedText.length,
|
|
value: value.slice(0, cursor) + cleanedText + value.slice(cursor)
|
|
}
|
|
}
|
|
|
|
const label = pasteTokenLabel(cleanedText, lineCount)
|
|
const lead = cursor > 0 && !/\s/.test(value[cursor - 1] ?? '') ? ' ' : ''
|
|
const tail = cursor < value.length && !/\s/.test(value[cursor] ?? '') ? ' ' : ''
|
|
const insert = `${lead}${label}${tail}`
|
|
|
|
setPasteSnips(prev => [...prev, { label, text: cleanedText }].slice(-32))
|
|
|
|
return {
|
|
cursor: cursor + insert.length,
|
|
value: value.slice(0, cursor) + insert + value.slice(cursor)
|
|
}
|
|
},
|
|
[onClipboardPaste]
|
|
)
|
|
|
|
const openEditor = useCallback(() => {
|
|
const editor = process.env.EDITOR || process.env.VISUAL || 'vi'
|
|
const file = join(mkdtempSync(join(tmpdir(), 'hermes-')), 'prompt.md')
|
|
|
|
writeFileSync(file, [...inputBuf, input].join('\n'))
|
|
process.stdout.write('\x1b[?1049l')
|
|
const { status: code } = spawnSync(editor, [file], { stdio: 'inherit' })
|
|
process.stdout.write('\x1b[?1049h\x1b[2J\x1b[H')
|
|
|
|
if (code === 0) {
|
|
const text = readFileSync(file, 'utf8').trimEnd()
|
|
|
|
if (text) {
|
|
setInput('')
|
|
setInputBuf([])
|
|
submitRef.current(text)
|
|
}
|
|
}
|
|
|
|
rmSync(file, { force: true })
|
|
}, [input, inputBuf, submitRef])
|
|
|
|
const actions = useMemo(
|
|
() => ({
|
|
clearIn,
|
|
dequeue,
|
|
enqueue,
|
|
handleTextPaste,
|
|
openEditor,
|
|
pushHistory,
|
|
replaceQueue: replaceQ,
|
|
setCompIdx,
|
|
setHistoryIdx,
|
|
setInput,
|
|
setInputBuf,
|
|
setPasteSnips,
|
|
setQueueEdit,
|
|
syncQueue
|
|
}),
|
|
[
|
|
clearIn,
|
|
dequeue,
|
|
enqueue,
|
|
handleTextPaste,
|
|
openEditor,
|
|
pushHistory,
|
|
replaceQ,
|
|
setCompIdx,
|
|
setHistoryIdx,
|
|
setQueueEdit,
|
|
syncQueue
|
|
]
|
|
)
|
|
|
|
const refs = useMemo(
|
|
() => ({
|
|
historyDraftRef,
|
|
historyRef,
|
|
queueEditRef,
|
|
queueRef,
|
|
submitRef
|
|
}),
|
|
[historyDraftRef, historyRef, queueEditRef, queueRef, submitRef]
|
|
)
|
|
|
|
const state = useMemo(
|
|
() => ({
|
|
compIdx,
|
|
compReplace,
|
|
completions,
|
|
historyIdx,
|
|
input,
|
|
inputBuf,
|
|
pasteSnips,
|
|
queueEditIdx,
|
|
queuedDisplay
|
|
}),
|
|
[compIdx, compReplace, completions, historyIdx, input, inputBuf, pasteSnips, queueEditIdx, queuedDisplay]
|
|
)
|
|
|
|
return {
|
|
actions,
|
|
refs,
|
|
state
|
|
}
|
|
}
|