common/hermes
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: make CLI status bar skin-aware

Browse Source 
Route prompt_toolkit status bar colors through the skin engine so /skin updates the status bar alongside the rest of the interactive TUI.

Add regression coverage for the new status bar style override keys and CLI style composition.
This commit is contained in:
kshitij
2026-03-18 08:57:56 +05:30
committed by Teknium
parent de849c410d
commit c323217188
3 changed files with 268 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/hermes_cli/test_skin_engine.py
View File

@@ -267,8 +267,9 @@ class TestCliBrandingHelpers:
assert get_active_goodbye() == "Farewell, warrior! ⚔"
def test_prompt_toolkit_style_overrides_cover_tui_classes(self):
from hermes_cli.skin_engine import set_active_skin, get_prompt_toolkit_style_overrides
from hermes_cli.skin_engine import set_active_skin, set_theme_mode, get_prompt_toolkit_style_overrides
set_theme_mode("dark")
set_active_skin("ares")
overrides = get_prompt_toolkit_style_overrides()
required = {
@@ -277,6 +278,13 @@ class TestCliBrandingHelpers:
"prompt",
"prompt-working",
"hint",
"status-bar",
"status-bar-strong",
"status-bar-dim",
"status-bar-good",
"status-bar-warn",
"status-bar-bad",
"status-bar-critical",
"input-rule",
"image-badge",
"completion-menu",
@@ -316,15 +324,26 @@ class TestCliBrandingHelpers:
def test_prompt_toolkit_style_overrides_use_skin_colors(self):
from hermes_cli.skin_engine import (
set_active_skin,
set_theme_mode,
get_active_skin,
get_prompt_toolkit_style_overrides,
)
set_theme_mode("dark")
set_active_skin("ares")
skin = get_active_skin()
overrides = get_prompt_toolkit_style_overrides()
assert overrides["prompt"] == skin.get_color("prompt")
assert overrides["input-rule"] == skin.get_color("input_rule")
assert overrides["status-bar"] == (
f"bg:{skin.get_color('status_bar_bg')} {skin.get_color('status_bar_text')}"
)
assert overrides["status-bar-strong"] == (
f"bg:{skin.get_color('status_bar_bg')} {skin.get_color('status_bar_strong')} bold"
)
assert overrides["status-bar-critical"] == (
f"bg:{skin.get_color('status_bar_bg')} {skin.get_color('status_bar_critical')} bold"
)
assert overrides["clarify-title"] == f"{skin.get_color('banner_title')} bold"
assert overrides["sudo-prompt"] == f"{skin.get_color('ui_error')} bold"
assert overrides["approval-title"] == f"{skin.get_color('ui_warn')} bold"

6
tests/test_cli_skin_integration.py
View File

@@ -59,6 +59,9 @@ class TestCliSkinPromptIntegration:
def test_build_tui_style_dict_uses_skin_overrides(self):
cli = _make_cli_stub()
from hermes_cli.skin_engine import set_theme_mode
set_theme_mode("dark")
set_active_skin("ares")
skin = get_active_skin()
style_dict = cli._build_tui_style_dict()
@@ -66,6 +69,9 @@ class TestCliSkinPromptIntegration:
assert style_dict["prompt"] == skin.get_color("prompt")
assert style_dict["input-rule"] == skin.get_color("input_rule")
assert style_dict["prompt-working"] == f"{skin.get_color('banner_dim')} italic"
assert style_dict["status-bar"] == (
f"bg:{skin.get_color('status_bar_bg')} {skin.get_color('status_bar_text')}"
)
assert style_dict["approval-title"] == f"{skin.get_color('ui_warn')} bold"
def test_apply_tui_skin_style_updates_running_app(self):