From a5063ff105dd154b8d250f09f23611a1416ca9e0 Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Mon, 20 Apr 2026 01:41:27 -0700 Subject: [PATCH] docs(providers): drop stale 'TODO: Phase 4' from get_provider docstring (#12902) User-defined providers from config.yaml are already resolved via resolve_provider_full() (which layers resolve_user_provider and resolve_custom_provider on top of get_provider). Refresh the docstring to reflect current reality and point future readers at the right entry point. No behaviour change. Closes #12309. --- hermes_cli/providers.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hermes_cli/providers.py b/hermes_cli/providers.py index a71055cfe..c701db4d5 100644 --- a/hermes_cli/providers.py +++ b/hermes_cli/providers.py @@ -322,12 +322,16 @@ def normalize_provider(name: str) -> str: def get_provider(name: str) -> Optional[ProviderDef]: - """Look up a provider by id or alias, merging all data sources. + """Look up a built-in provider by id or alias. Resolution order: 1. Hermes overlays (for providers not in models.dev: nous, openai-codex, etc.) 2. models.dev catalog + Hermes overlay - 3. User-defined providers from config (TODO: Phase 4) + + User-defined providers from config.yaml (``providers:`` / ``custom_providers:``) + are resolved by :func:`resolve_provider_full`, which layers ``resolve_user_provider`` + and ``resolve_custom_provider`` on top of this function. Callers that need + user-config support should use ``resolve_provider_full`` instead. Returns a fully-resolved ProviderDef or None. """