feat(tui): opt-in auto-resume of the most recent session (#17130)
* feat(tui): opt-in auto-resume of the most recent session
`hermes --tui` always forges a fresh session at startup unless the user
sets `HERMES_TUI_RESUME=<id>`. Disconnects, terminal-window crashes,
and accidental Ctrl+D therefore lose every piece of in-flight context
even though `state.db` still has the full history a `/resume` away.
Add an opt-in path that mirrors classic CLI's `hermes -c` muscle
memory: when `display.tui_auto_resume_recent: true` is set in
`~/.hermes/config.yaml`, the TUI looks up the most recent human-facing
session and resumes it instead of starting fresh. Default off so
existing users aren't surprised; explicit `HERMES_TUI_RESUME` always
wins.
Wires:
* New `session.most_recent` JSON-RPC in `tui_gateway/server.py` that
returns the first non-`tool` row from `list_sessions_rich`, or
`{"session_id": null}` when none. Uses the same deny-list as
`session.list` so sub-agent rows can't sneak in.
* `createGatewayEventHandler.handleReady` re-ordered: explicit
`STARTUP_RESUME_ID` first (unchanged), then conditional auto-resume
via `config.get full → display.tui_auto_resume_recent`, then the
legacy `newSession()` fallback. Failures of either RPC fall back
to `newSession()` so the path is always finite.
* Default `display.tui_auto_resume_recent: False` added to
`DEFAULT_CONFIG` in `hermes_cli/config.py` (no `_config_version`
bump per AGENTS.md — deep-merge handles the additive key).
Tests:
* 4 new vitest cases in `createGatewayEventHandler.test.ts` cover
every gate-and-fallback combination (env wins, config off, config
on with hit, config on with miss).
* 3 new pytest cases for `session.most_recent` (denied row skip,
tool-only → null, db-unavailable → null).
Validation:
scripts/run_tests.sh tests/test_tui_gateway_server.py — 93/93.
cd ui-tui && npm run type-check — clean; npm test --run — 393/393.
* review(copilot): fold session.most_recent errors into null + extend ConfigDisplayConfig
* review(copilot): cover RPC-rejection fallbacks in auto-resume tests
This commit is contained in:
@@ -1788,6 +1788,50 @@ def _(rid, params: dict) -> dict:
|
||||
return _err(rid, 5006, str(e))
|
||||
|
||||
|
||||
@method("session.most_recent")
|
||||
def _(rid, params: dict) -> dict:
|
||||
"""Return the most recent human-facing session id, or ``None``.
|
||||
|
||||
Mirrors ``session.list``'s deny-list behaviour (drops ``tool``
|
||||
sub-agent rows). Used by TUI auto-resume when
|
||||
``display.tui_auto_resume_recent`` is on; the field is also handy
|
||||
for any CLI tooling that wants "latest session" without paginating
|
||||
the full list.
|
||||
|
||||
Contract: a ``{"session_id": null}`` result means "no eligible
|
||||
session found right now". Errors are also folded into that
|
||||
null-result shape (and logged) so callers don't have to special-
|
||||
case JSON-RPC error envelopes for what is a normal "no answer".
|
||||
"""
|
||||
db = _get_db()
|
||||
if db is None:
|
||||
return _ok(rid, {"session_id": None})
|
||||
try:
|
||||
deny = frozenset({"tool"})
|
||||
# Over-fetch by a generous bounded amount so heavy sub-agent
|
||||
# users (lots of recent ``tool`` rows) don't get a false
|
||||
# "no eligible session" answer. ``session.list`` uses a
|
||||
# similar over-fetch strategy.
|
||||
rows = db.list_sessions_rich(source=None, limit=200)
|
||||
for row in rows:
|
||||
src = (row.get("source") or "").strip().lower()
|
||||
if src in deny:
|
||||
continue
|
||||
return _ok(
|
||||
rid,
|
||||
{
|
||||
"session_id": row.get("id"),
|
||||
"title": row.get("title") or "",
|
||||
"started_at": row.get("started_at") or 0,
|
||||
"source": row.get("source") or "",
|
||||
},
|
||||
)
|
||||
return _ok(rid, {"session_id": None})
|
||||
except Exception:
|
||||
logger.exception("session.most_recent failed")
|
||||
return _ok(rid, {"session_id": None})
|
||||
|
||||
|
||||
@method("session.resume")
|
||||
def _(rid, params: dict) -> dict:
|
||||
target = params.get("session_id", "")
|
||||
|
||||
Reference in New Issue
Block a user