feat(irc): add interactive setup
feat(gateway): refine Platform._missing_ and platform-connected dispatch Restricts plugin-name acceptance to bundled plugin scan + registry (no arbitrary string -> enum-pollution), pulls per-platform connectivity checks into a _PLATFORM_CONNECTED_CHECKERS lambda map with a clean _is_platform_connected method, and adds tests covering the checker map, plugin platform interface, and IRC setup wizard.
This commit is contained in:
Ari Lotter
@@ -300,6 +300,129 @@ class TestIRCAdapterMessageParsing:
|
||||
assert len(dispatched) == 1
|
||||
assert dispatched[0]["text"] == "* user waves"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_allowed_users_case_insensitive(self, monkeypatch):
|
||||
"""Allowlist should match nicks case-insensitively."""
|
||||
for key in ("IRC_SERVER", "IRC_PORT", "IRC_NICKNAME", "IRC_CHANNEL", "IRC_USE_TLS"):
|
||||
monkeypatch.delenv(key, raising=False)
|
||||
from gateway.config import PlatformConfig
|
||||
cfg = PlatformConfig(
|
||||
enabled=True,
|
||||
extra={
|
||||
"server": "localhost",
|
||||
"port": 6667,
|
||||
"nickname": "hermes",
|
||||
"channel": "#test",
|
||||
"use_tls": False,
|
||||
"allowed_users": ["Admin", "BOB"],
|
||||
},
|
||||
)
|
||||
adapter = IRCAdapter(cfg)
|
||||
adapter._current_nick = "hermes"
|
||||
adapter._registered = True
|
||||
dispatched = []
|
||||
|
||||
async def capture_dispatch(**kwargs):
|
||||
dispatched.append(kwargs)
|
||||
|
||||
adapter._dispatch_message = capture_dispatch
|
||||
adapter._message_handler = AsyncMock()
|
||||
|
||||
# "admin" matches "Admin" in allowlist
|
||||
await adapter._handle_line(":admin!u@host PRIVMSG #test :hermes: hello")
|
||||
assert len(dispatched) == 1
|
||||
assert dispatched[0]["text"] == "hello"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_unauthorized_user_blocked(self, monkeypatch):
|
||||
"""Nicks not in allowlist should be ignored."""
|
||||
for key in ("IRC_SERVER", "IRC_PORT", "IRC_NICKNAME", "IRC_CHANNEL", "IRC_USE_TLS"):
|
||||
monkeypatch.delenv(key, raising=False)
|
||||
from gateway.config import PlatformConfig
|
||||
cfg = PlatformConfig(
|
||||
enabled=True,
|
||||
extra={
|
||||
"server": "localhost",
|
||||
"port": 6667,
|
||||
"nickname": "hermes",
|
||||
"channel": "#test",
|
||||
"use_tls": False,
|
||||
"allowed_users": ["Admin", "BOB"],
|
||||
},
|
||||
)
|
||||
adapter = IRCAdapter(cfg)
|
||||
adapter._current_nick = "hermes"
|
||||
adapter._registered = True
|
||||
dispatched = []
|
||||
|
||||
async def capture_dispatch(**kwargs):
|
||||
dispatched.append(kwargs)
|
||||
|
||||
adapter._dispatch_message = capture_dispatch
|
||||
adapter._message_handler = AsyncMock()
|
||||
|
||||
await adapter._handle_line(":eve!u@host PRIVMSG #test :hermes: hello")
|
||||
assert len(dispatched) == 0
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_nick_collision_retry(self, adapter):
|
||||
"""Multiple 433 responses should keep incrementing the suffix."""
|
||||
writer = MagicMock()
|
||||
writer.is_closing = MagicMock(return_value=False)
|
||||
writer.write = MagicMock()
|
||||
writer.drain = AsyncMock()
|
||||
adapter._writer = writer
|
||||
|
||||
await adapter._handle_line(":server 433 * hermes :Nickname in use")
|
||||
assert adapter._current_nick == "hermes_"
|
||||
await adapter._handle_line(":server 433 * hermes_ :Nickname in use")
|
||||
assert adapter._current_nick == "hermes_1"
|
||||
await adapter._handle_line(":server 433 * hermes_1 :Nickname in use")
|
||||
assert adapter._current_nick == "hermes_2"
|
||||
|
||||
|
||||
class TestIRCAdapterSplitting:
|
||||
|
||||
def test_split_respects_byte_limit(self):
|
||||
"""Multi-byte characters should not exceed IRC byte limit."""
|
||||
# 100 japanese chars = 300 bytes in utf-8
|
||||
text = "あ" * 100
|
||||
from gateway.config import PlatformConfig
|
||||
cfg = PlatformConfig(enabled=True, extra={"server": "x", "channel": "#x"})
|
||||
adapter = IRCAdapter(cfg)
|
||||
adapter._current_nick = "bot"
|
||||
lines = adapter._split_message(text, "#test")
|
||||
for line in lines:
|
||||
overhead = len(f"PRIVMSG #test :{line}\r\n".encode("utf-8"))
|
||||
assert overhead <= 512, f"line over 512 bytes: {overhead}"
|
||||
|
||||
def test_split_prefers_word_boundary(self):
|
||||
text = "hello world foo bar baz qux"
|
||||
from gateway.config import PlatformConfig
|
||||
cfg = PlatformConfig(enabled=True, extra={"server": "x", "channel": "#x"})
|
||||
adapter = IRCAdapter(cfg)
|
||||
adapter._current_nick = "bot"
|
||||
lines = adapter._split_message(text, "#test")
|
||||
# Should not split in the middle of "world"
|
||||
assert any("hello" in ln for ln in lines)
|
||||
assert any("world" in ln for ln in lines)
|
||||
|
||||
|
||||
class TestIRCProtocolHelpersExtra:
|
||||
|
||||
def test_parse_malformed_no_space(self):
|
||||
"""A line starting with : but no space should not crash."""
|
||||
msg = _parse_irc_message(":justaprefix")
|
||||
assert msg["prefix"] == "justaprefix"
|
||||
assert msg["command"] == ""
|
||||
assert msg["params"] == []
|
||||
|
||||
def test_parse_empty(self):
|
||||
msg = _parse_irc_message("")
|
||||
assert msg["prefix"] == ""
|
||||
assert msg["command"] == ""
|
||||
assert msg["params"] == []
|
||||
|
||||
|
||||
class TestIRCAdapterMarkdown:
|
||||
|
||||
|
||||
99
tests/gateway/test_platform_connected_checkers.py
Normal file
99
tests/gateway/test_platform_connected_checkers.py
Normal file
@@ -0,0 +1,99 @@
|
||||
"""
|
||||
Verify that every gateway platform — built-in and plugin — has a connection
|
||||
checker so ``GatewayConfig.get_connected_platforms()`` doesn't silently drop
|
||||
platforms with bespoke auth requirements.
|
||||
"""
|
||||
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
import pytest
|
||||
|
||||
from gateway.config import Platform, _PLATFORM_CONNECTED_CHECKERS, _BUILTIN_PLATFORM_VALUES
|
||||
|
||||
|
||||
def test_all_builtins_have_checker_or_generic_token_path():
|
||||
"""Every built-in Platform member must be reachable by either:
|
||||
|
||||
1. The generic ``config.token or config.api_key`` check, OR
|
||||
2. A platform-specific entry in ``_PLATFORM_CONNECTED_CHECKERS``.
|
||||
|
||||
This guarantees ``get_connected_platforms()`` doesn't silently ignore
|
||||
a built-in just because nobody added it to the checker dict.
|
||||
"""
|
||||
# Platforms covered by the generic token/api_key branch
|
||||
generic_token_values = {p.value for p in {
|
||||
Platform.TELEGRAM,
|
||||
Platform.DISCORD,
|
||||
Platform.SLACK,
|
||||
Platform.MATRIX,
|
||||
Platform.MATTERMOST,
|
||||
Platform.HOMEASSISTANT,
|
||||
}}
|
||||
|
||||
# Platforms with a bespoke checker
|
||||
checker_values = {p.value for p in set(_PLATFORM_CONNECTED_CHECKERS.keys())}
|
||||
|
||||
# Every built-in should be in one of the two sets
|
||||
all_builtins = set(_BUILTIN_PLATFORM_VALUES)
|
||||
missing = all_builtins - generic_token_values - checker_values - {"local"}
|
||||
|
||||
assert not missing, (
|
||||
f"Built-in platforms missing a connection checker: "
|
||||
f"{sorted(missing)}. "
|
||||
f"Add them to _PLATFORM_CONNECTED_CHECKERS or generic_token_platforms."
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform, checker", list(_PLATFORM_CONNECTED_CHECKERS.items()))
|
||||
def test_checker_handles_minimal_config(platform, checker):
|
||||
"""Each bespoke checker must not crash on a minimal PlatformConfig."""
|
||||
mock_config = MagicMock()
|
||||
mock_config.extra = {}
|
||||
mock_config.token = None
|
||||
mock_config.api_key = None
|
||||
mock_config.enabled = True
|
||||
|
||||
# Should return a bool without raising
|
||||
result = checker(mock_config)
|
||||
assert isinstance(result, bool)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform, checker", list(_PLATFORM_CONNECTED_CHECKERS.items()))
|
||||
def test_checker_returns_true_when_configured(platform, checker, monkeypatch):
|
||||
"""Each bespoke checker must return True when the config looks valid."""
|
||||
mock_config = MagicMock()
|
||||
mock_config.token = None
|
||||
mock_config.api_key = None
|
||||
mock_config.enabled = True
|
||||
|
||||
# Set up platform-specific mock extra fields so the checker succeeds
|
||||
if platform == Platform.WEIXIN:
|
||||
mock_config.extra = {"account_id": "123", "token": "***"}
|
||||
elif platform == Platform.SIGNAL:
|
||||
mock_config.extra = {"http_url": "http://signal:8080"}
|
||||
elif platform == Platform.EMAIL:
|
||||
mock_config.extra = {"address": "hermes@example.com"}
|
||||
elif platform == Platform.SMS:
|
||||
monkeypatch.setenv("TWILIO_ACCOUNT_SID", "ACtest")
|
||||
mock_config.extra = {}
|
||||
elif platform in (Platform.API_SERVER, Platform.WEBHOOK, Platform.WHATSAPP):
|
||||
mock_config.extra = {}
|
||||
elif platform == Platform.FEISHU:
|
||||
mock_config.extra = {"app_id": "app"}
|
||||
elif platform == Platform.WECOM:
|
||||
mock_config.extra = {"bot_id": "bot"}
|
||||
elif platform == Platform.WECOM_CALLBACK:
|
||||
mock_config.extra = {"corp_id": "corp"}
|
||||
elif platform == Platform.BLUEBUBBLES:
|
||||
mock_config.extra = {"server_url": "http://bb:1234", "password": "pw"}
|
||||
elif platform == Platform.QQBOT:
|
||||
mock_config.extra = {"app_id": "app", "client_secret": "sec"}
|
||||
elif platform == Platform.YUANBAO:
|
||||
mock_config.extra = {"app_id": "app", "app_secret": "sec"}
|
||||
elif platform == Platform.DINGTALK:
|
||||
mock_config.extra = {"client_id": "id", "client_secret": "sec"}
|
||||
else:
|
||||
pytest.skip(f"No synthetic config defined for {platform.value}")
|
||||
|
||||
result = checker(mock_config)
|
||||
assert result is True, f"{platform.value} checker should return True with valid-looking config"
|
||||
@@ -38,9 +38,28 @@ class TestPlatformEnumDynamic:
|
||||
assert a.value == "irc"
|
||||
|
||||
def test_dynamic_member_with_hyphens(self):
|
||||
p = Platform("my-platform")
|
||||
assert p.value == "my-platform"
|
||||
assert p.name == "MY_PLATFORM"
|
||||
"""Registered plugin platforms with hyphens work once registered."""
|
||||
from gateway.platform_registry import platform_registry as _reg
|
||||
|
||||
entry = PlatformEntry(
|
||||
name="my-platform",
|
||||
label="My Platform",
|
||||
adapter_factory=lambda cfg: MagicMock(),
|
||||
check_fn=lambda: True,
|
||||
source="plugin",
|
||||
)
|
||||
_reg.register(entry)
|
||||
try:
|
||||
p = Platform("my-platform")
|
||||
assert p.value == "my-platform"
|
||||
assert p.name == "MY_PLATFORM"
|
||||
finally:
|
||||
_reg.unregister("my-platform")
|
||||
|
||||
def test_dynamic_member_rejects_unregistered(self):
|
||||
"""Arbitrary strings are rejected to prevent enum pollution."""
|
||||
with pytest.raises(ValueError):
|
||||
Platform("totally-fake-platform")
|
||||
|
||||
def test_dynamic_member_rejects_non_string(self):
|
||||
with pytest.raises(ValueError):
|
||||
|
||||
230
tests/gateway/test_plugin_platform_interface.py
Normal file
230
tests/gateway/test_plugin_platform_interface.py
Normal file
@@ -0,0 +1,230 @@
|
||||
"""
|
||||
Interface compliance tests for all plugin-based gateway platforms.
|
||||
|
||||
Discovers platforms dynamically under ``plugins/platforms/`` — no manual
|
||||
enumeration — and verifies each one implements the required contract.
|
||||
"""
|
||||
|
||||
import importlib
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from types import ModuleType
|
||||
from typing import Any
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
import pytest
|
||||
|
||||
PROJECT_ROOT = Path(__file__).parent.parent.resolve()
|
||||
PLATFORMS_DIR = PROJECT_ROOT / "plugins" / "platforms"
|
||||
|
||||
|
||||
def _discover_platform_plugins() -> list[str]:
|
||||
"""Return names of all bundled platform plugins."""
|
||||
if not PLATFORMS_DIR.is_dir():
|
||||
return []
|
||||
names = []
|
||||
for child in sorted(PLATFORMS_DIR.iterdir()):
|
||||
if child.is_dir() and (child / "__init__.py").exists():
|
||||
names.append(child.name)
|
||||
return names
|
||||
|
||||
|
||||
# Dynamically parametrise over discovered platforms
|
||||
_PLATFORM_NAMES = _discover_platform_plugins()
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def clean_registry():
|
||||
"""Yield with a clean platform registry, restoring state afterwards."""
|
||||
from gateway.platform_registry import platform_registry
|
||||
|
||||
original = dict(platform_registry._entries)
|
||||
platform_registry._entries.clear()
|
||||
yield platform_registry
|
||||
platform_registry._entries.clear()
|
||||
platform_registry._entries.update(original)
|
||||
|
||||
|
||||
class _MockPluginContext:
|
||||
"""Minimal mock of hermes_cli.plugins.PluginContext.
|
||||
|
||||
Only implements register_platform so we can exercise the plugin's
|
||||
register() entrypoint without importing the real plugin system.
|
||||
"""
|
||||
|
||||
def __init__(self):
|
||||
self.registered_names: list[str] = []
|
||||
|
||||
def register_platform(
|
||||
self,
|
||||
*,
|
||||
name: str,
|
||||
label: str,
|
||||
adapter_factory: Any,
|
||||
check_fn: Any,
|
||||
**kwargs: Any,
|
||||
) -> None:
|
||||
from gateway.platform_registry import platform_registry, PlatformEntry
|
||||
|
||||
entry = PlatformEntry(
|
||||
name=name,
|
||||
label=label,
|
||||
adapter_factory=adapter_factory,
|
||||
check_fn=check_fn,
|
||||
**kwargs,
|
||||
)
|
||||
platform_registry.register(entry)
|
||||
self.registered_names.append(name)
|
||||
|
||||
|
||||
def _import_platform_module(name: str) -> ModuleType:
|
||||
"""Import plugins.platforms.<name> in a test-safe way."""
|
||||
# Make sure the project root is on sys.path so relative imports work
|
||||
if str(PROJECT_ROOT) not in sys.path:
|
||||
sys.path.insert(0, str(PROJECT_ROOT))
|
||||
module = importlib.import_module(f"plugins.platforms.{name}")
|
||||
return module
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_plugin_exposes_register_function(platform_name: str):
|
||||
"""Every platform plugin must expose a callable register function."""
|
||||
module = _import_platform_module(platform_name)
|
||||
assert hasattr(module, "register"), f"{platform_name} missing register()"
|
||||
assert callable(module.register), f"{platform_name}.register not callable"
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_plugin_registers_valid_platform_entry(platform_name: str, clean_registry):
|
||||
"""Calling register() must create a valid PlatformEntry."""
|
||||
module = _import_platform_module(platform_name)
|
||||
ctx = _MockPluginContext()
|
||||
module.register(ctx)
|
||||
|
||||
assert platform_name in ctx.registered_names
|
||||
|
||||
from gateway.platform_registry import platform_registry
|
||||
entry = platform_registry.get(platform_name)
|
||||
assert entry is not None, f"{platform_name} did not register an entry"
|
||||
assert entry.name == platform_name
|
||||
assert entry.label
|
||||
assert callable(entry.adapter_factory)
|
||||
assert callable(entry.check_fn)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_platform_entry_has_required_fields(platform_name: str, clean_registry):
|
||||
"""PlatformEntry must have the mandatory metadata fields."""
|
||||
module = _import_platform_module(platform_name)
|
||||
ctx = _MockPluginContext()
|
||||
module.register(ctx)
|
||||
|
||||
from gateway.platform_registry import platform_registry
|
||||
entry = platform_registry.get(platform_name)
|
||||
assert entry is not None
|
||||
|
||||
# Mandatory fields
|
||||
assert isinstance(entry.name, str) and entry.name
|
||||
assert isinstance(entry.label, str) and entry.label
|
||||
assert callable(entry.adapter_factory)
|
||||
assert callable(entry.check_fn)
|
||||
|
||||
# Optional but recommended fields
|
||||
if entry.validate_config is not None:
|
||||
assert callable(entry.validate_config)
|
||||
if entry.is_connected is not None:
|
||||
assert callable(entry.is_connected)
|
||||
if entry.setup_fn is not None:
|
||||
assert callable(entry.setup_fn)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_adapter_factory_produces_valid_adapter(platform_name: str, clean_registry):
|
||||
"""The adapter factory must return an object with the base interface."""
|
||||
module = _import_platform_module(platform_name)
|
||||
ctx = _MockPluginContext()
|
||||
module.register(ctx)
|
||||
|
||||
from gateway.platform_registry import platform_registry
|
||||
entry = platform_registry.get(platform_name)
|
||||
assert entry is not None
|
||||
|
||||
# Build a minimal synthetic config that shouldn't crash __init__
|
||||
mock_config = MagicMock()
|
||||
mock_config.extra = {}
|
||||
mock_config.enabled = True
|
||||
mock_config.token = None
|
||||
mock_config.api_key = None
|
||||
mock_config.home_channel = None
|
||||
mock_config.reply_to_mode = "first"
|
||||
|
||||
adapter = entry.adapter_factory(mock_config)
|
||||
assert adapter is not None, f"{platform_name} adapter_factory returned None"
|
||||
|
||||
# Required adapter interface
|
||||
assert hasattr(adapter, "connect") and callable(adapter.connect)
|
||||
assert hasattr(adapter, "disconnect") and callable(adapter.disconnect)
|
||||
assert hasattr(adapter, "send") and callable(adapter.send)
|
||||
assert hasattr(adapter, "name")
|
||||
|
||||
# Should be a BasePlatformAdapter subclass if importable
|
||||
try:
|
||||
from gateway.platforms.base import BasePlatformAdapter
|
||||
assert isinstance(adapter, BasePlatformAdapter)
|
||||
except Exception:
|
||||
pytest.skip("BasePlatformAdapter not available for isinstance check")
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_check_fn_returns_bool(platform_name: str, clean_registry):
|
||||
"""check_fn() must return a boolean."""
|
||||
module = _import_platform_module(platform_name)
|
||||
ctx = _MockPluginContext()
|
||||
module.register(ctx)
|
||||
|
||||
from gateway.platform_registry import platform_registry
|
||||
entry = platform_registry.get(platform_name)
|
||||
assert entry is not None
|
||||
|
||||
result = entry.check_fn()
|
||||
assert isinstance(result, bool), f"{platform_name}.check_fn() returned {type(result)}, expected bool"
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_validate_config_if_present(platform_name: str, clean_registry):
|
||||
"""If validate_config is provided, it must accept a config object."""
|
||||
module = _import_platform_module(platform_name)
|
||||
ctx = _MockPluginContext()
|
||||
module.register(ctx)
|
||||
|
||||
from gateway.platform_registry import platform_registry
|
||||
entry = platform_registry.get(platform_name)
|
||||
assert entry is not None
|
||||
|
||||
if entry.validate_config is None:
|
||||
pytest.skip("No validate_config provided")
|
||||
|
||||
mock_config = MagicMock()
|
||||
mock_config.extra = {}
|
||||
result = entry.validate_config(mock_config)
|
||||
assert isinstance(result, bool)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("platform_name", _PLATFORM_NAMES)
|
||||
def test_is_connected_if_present(platform_name: str, clean_registry):
|
||||
"""If is_connected is provided, it must accept a config object."""
|
||||
module = _import_platform_module(platform_name)
|
||||
ctx = _MockPluginContext()
|
||||
module.register(ctx)
|
||||
|
||||
from gateway.platform_registry import platform_registry
|
||||
entry = platform_registry.get(platform_name)
|
||||
assert entry is not None
|
||||
|
||||
if entry.is_connected is None:
|
||||
pytest.skip("No is_connected provided")
|
||||
|
||||
mock_config = MagicMock()
|
||||
mock_config.extra = {}
|
||||
result = entry.is_connected(mock_config)
|
||||
assert isinstance(result, bool)
|
||||
@@ -89,12 +89,14 @@ class TestSessionSourceRoundtrip:
|
||||
assert restored.chat_topic is None
|
||||
assert restored.chat_type == "dm"
|
||||
|
||||
def test_unknown_platform_accepted_for_plugins(self):
|
||||
"""Unknown platform names are now accepted (dynamic enum members for
|
||||
plugin platforms), so from_dict should succeed rather than raise."""
|
||||
source = SessionSource.from_dict({"platform": "nonexistent", "chat_id": "1"})
|
||||
assert source.platform.value == "nonexistent"
|
||||
assert source.chat_id == "1"
|
||||
def test_unknown_platform_rejected_for_bad_names(self):
|
||||
"""Arbitrary platform names are rejected (no accidental enum pollution).
|
||||
|
||||
Only bundled platform plugins (discovered under ``plugins/platforms/``)
|
||||
and runtime-registered plugins get dynamic enum members.
|
||||
"""
|
||||
with pytest.raises(ValueError):
|
||||
SessionSource.from_dict({"platform": "nonexistent", "chat_id": "1"})
|
||||
|
||||
|
||||
class TestSessionSourceDescription:
|
||||
|
||||
@@ -552,6 +552,19 @@ class TestResolveApiKeyProviderCredentials:
|
||||
creds = resolve_api_key_provider_credentials("gmi")
|
||||
assert creds["base_url"] == "https://custom.gmi.example/v1"
|
||||
|
||||
def test_resolve_gmi_with_key(self, monkeypatch):
|
||||
monkeypatch.setenv("GMI_API_KEY", "gmi-secret-key")
|
||||
creds = resolve_api_key_provider_credentials("gmi")
|
||||
assert creds["provider"] == "gmi"
|
||||
assert creds["api_key"] == "gmi-secret-key"
|
||||
assert creds["base_url"] == "https://api.gmi-serving.com/v1"
|
||||
|
||||
def test_resolve_gmi_custom_base_url(self, monkeypatch):
|
||||
monkeypatch.setenv("GMI_API_KEY", "gmi-key")
|
||||
monkeypatch.setenv("GMI_BASE_URL", "https://custom.gmi.example/v1")
|
||||
creds = resolve_api_key_provider_credentials("gmi")
|
||||
assert creds["base_url"] == "https://custom.gmi.example/v1"
|
||||
|
||||
def test_resolve_kilocode_custom_base_url(self, monkeypatch):
|
||||
monkeypatch.setenv("KILOCODE_API_KEY", "kilo-key")
|
||||
monkeypatch.setenv("KILOCODE_BASE_URL", "https://custom.kilo.example/v1")
|
||||
|
||||
@@ -430,6 +430,43 @@ def test_run_doctor_accepts_hermes_provider_ids_that_catalog_aliases(
|
||||
)
|
||||
|
||||
|
||||
def test_run_doctor_accepts_bare_custom_provider(monkeypatch, tmp_path):
|
||||
home = tmp_path / ".hermes"
|
||||
home.mkdir(parents=True, exist_ok=True)
|
||||
(home / "config.yaml").write_text(
|
||||
"model:\n"
|
||||
" provider: custom\n"
|
||||
" default: local-model\n"
|
||||
" base_url: http://localhost:8000/v1\n",
|
||||
encoding="utf-8",
|
||||
)
|
||||
|
||||
monkeypatch.setattr(doctor_mod, "HERMES_HOME", home)
|
||||
monkeypatch.setattr(doctor_mod, "PROJECT_ROOT", tmp_path / "project")
|
||||
monkeypatch.setattr(doctor_mod, "_DHH", str(home))
|
||||
(tmp_path / "project").mkdir(exist_ok=True)
|
||||
|
||||
fake_model_tools = types.SimpleNamespace(
|
||||
check_tool_availability=lambda *a, **kw: ([], []),
|
||||
TOOLSET_REQUIREMENTS={},
|
||||
)
|
||||
monkeypatch.setitem(sys.modules, "model_tools", fake_model_tools)
|
||||
|
||||
try:
|
||||
from hermes_cli import auth as _auth_mod
|
||||
monkeypatch.setattr(_auth_mod, "get_nous_auth_status", lambda: {})
|
||||
monkeypatch.setattr(_auth_mod, "get_codex_auth_status", lambda: {})
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
buf = io.StringIO()
|
||||
with contextlib.redirect_stdout(buf):
|
||||
doctor_mod.run_doctor(Namespace(fix=False))
|
||||
|
||||
out = buf.getvalue()
|
||||
assert "model.provider 'custom' is not a recognised provider" not in out
|
||||
|
||||
|
||||
def test_run_doctor_termux_does_not_mark_browser_available_without_agent_browser(monkeypatch, tmp_path):
|
||||
home = tmp_path / ".hermes"
|
||||
home.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
@@ -479,6 +479,69 @@ class TestAzureFoundryModelApiMode:
|
||||
assert azure_foundry_model_api_mode("Codex-Mini") == "codex_responses"
|
||||
|
||||
|
||||
class TestAzureFoundryModelApiMode:
|
||||
"""Azure Foundry deploys GPT-5.x / codex / o-series as Responses-API-only.
|
||||
|
||||
Azure returns ``400 "The requested operation is unsupported."`` when
|
||||
/chat/completions is called against these deployments. Verified in the
|
||||
wild by a user debug bundle on 2026-04-26: gpt-5.3-codex failed with
|
||||
that exact payload while gpt-4o-pure worked on the same endpoint.
|
||||
"""
|
||||
|
||||
def test_gpt5_family_uses_responses(self):
|
||||
assert azure_foundry_model_api_mode("gpt-5") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("gpt-5.3") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("gpt-5.4") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("gpt-5-codex") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("gpt-5.3-codex") == "codex_responses"
|
||||
# gpt-5-mini exceptions are Copilot-specific; Azure deploys the whole
|
||||
# gpt-5 family on Responses API uniformly.
|
||||
assert azure_foundry_model_api_mode("gpt-5-mini") == "codex_responses"
|
||||
|
||||
def test_codex_family_uses_responses(self):
|
||||
assert azure_foundry_model_api_mode("codex") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("codex-mini") == "codex_responses"
|
||||
|
||||
def test_o_series_reasoning_uses_responses(self):
|
||||
assert azure_foundry_model_api_mode("o1") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("o1-preview") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("o1-mini") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("o3") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("o3-mini") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("o4-mini") == "codex_responses"
|
||||
|
||||
def test_gpt4_family_returns_none(self):
|
||||
"""GPT-4, GPT-4o, etc. speak chat completions on Azure."""
|
||||
assert azure_foundry_model_api_mode("gpt-4") is None
|
||||
assert azure_foundry_model_api_mode("gpt-4o") is None
|
||||
assert azure_foundry_model_api_mode("gpt-4o-pure") is None
|
||||
assert azure_foundry_model_api_mode("gpt-4o-mini") is None
|
||||
assert azure_foundry_model_api_mode("gpt-4-turbo") is None
|
||||
assert azure_foundry_model_api_mode("gpt-4.1") is None
|
||||
assert azure_foundry_model_api_mode("gpt-3.5-turbo") is None
|
||||
|
||||
def test_non_openai_deployments_return_none(self):
|
||||
"""Llama, Mistral, Grok, etc. keep the default chat completions."""
|
||||
assert azure_foundry_model_api_mode("llama-3.1-70b") is None
|
||||
assert azure_foundry_model_api_mode("mistral-large") is None
|
||||
assert azure_foundry_model_api_mode("grok-4") is None
|
||||
assert azure_foundry_model_api_mode("phi-3-medium") is None
|
||||
|
||||
def test_vendor_prefix_stripped(self):
|
||||
"""Users who copy-paste ``openai/gpt-5.3-codex`` should still match."""
|
||||
assert azure_foundry_model_api_mode("openai/gpt-5.3-codex") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("openai/gpt-4o") is None
|
||||
|
||||
def test_empty_and_none_return_none(self):
|
||||
assert azure_foundry_model_api_mode(None) is None
|
||||
assert azure_foundry_model_api_mode("") is None
|
||||
assert azure_foundry_model_api_mode(" ") is None
|
||||
|
||||
def test_case_insensitive(self):
|
||||
assert azure_foundry_model_api_mode("GPT-5.3-Codex") == "codex_responses"
|
||||
assert azure_foundry_model_api_mode("Codex-Mini") == "codex_responses"
|
||||
|
||||
|
||||
# -- validate — format checks -----------------------------------------------
|
||||
|
||||
class TestValidateFormatChecks:
|
||||
|
||||
309
tests/hermes_cli/test_setup_irc.py
Normal file
309
tests/hermes_cli/test_setup_irc.py
Normal file
@@ -0,0 +1,309 @@
|
||||
"""Tests for IRC gateway configuration via `hermes setup gateway` UI.
|
||||
|
||||
Covers the full plugin-platform discovery → status → configure flow so that
|
||||
a fresh Hermes install (no state, no env vars) can set up IRC through the
|
||||
interactive setup menus.
|
||||
"""
|
||||
|
||||
import os
|
||||
import pytest
|
||||
|
||||
from gateway.platform_registry import PlatformEntry, platform_registry
|
||||
|
||||
|
||||
def _register_irc_platform(**overrides):
|
||||
"""Manually register the IRC platform entry as if discover_plugins() found it.
|
||||
|
||||
Tests run outside the normal plugin-discovery path, so we inject the entry
|
||||
directly into the singleton registry and yield its dict shape.
|
||||
"""
|
||||
needs_enable = overrides.pop("needs_enable", False)
|
||||
defaults = dict(
|
||||
name="irc",
|
||||
label="IRC",
|
||||
adapter_factory=lambda cfg: None,
|
||||
check_fn=lambda: bool(os.getenv("IRC_SERVER", "") and os.getenv("IRC_CHANNEL", "")),
|
||||
validate_config=None,
|
||||
required_env=["IRC_SERVER", "IRC_CHANNEL", "IRC_NICKNAME"],
|
||||
install_hint="No extra packages needed (stdlib only)",
|
||||
setup_fn=lambda: None,
|
||||
source="plugin",
|
||||
plugin_name="irc_platform",
|
||||
allowed_users_env="IRC_ALLOWED_USERS",
|
||||
allow_all_env="IRC_ALLOW_ALL_USERS",
|
||||
max_message_length=450,
|
||||
pii_safe=False,
|
||||
emoji="💬",
|
||||
allow_update_command=True,
|
||||
platform_hint="You are chatting via IRC.",
|
||||
)
|
||||
defaults.update(overrides)
|
||||
entry = PlatformEntry(**defaults)
|
||||
platform_registry.register(entry)
|
||||
return {
|
||||
"key": entry.name,
|
||||
"label": entry.label,
|
||||
"emoji": entry.emoji,
|
||||
"token_var": entry.required_env[0] if entry.required_env else "",
|
||||
"install_hint": entry.install_hint,
|
||||
"_registry_entry": entry,
|
||||
"needs_enable": needs_enable,
|
||||
}
|
||||
|
||||
|
||||
def _unregister_irc_platform():
|
||||
platform_registry.unregister("irc")
|
||||
|
||||
|
||||
# ── Fresh-install discovery ─────────────────────────────────────────────────
|
||||
|
||||
|
||||
class TestIRCFreshInstallDiscovery:
|
||||
"""IRC appears in the setup menu on a brand-new Hermes install."""
|
||||
|
||||
def test_irc_appears_in_all_platforms(self, monkeypatch):
|
||||
"""When the IRC plugin is registered, _all_platforms() surfaces it."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
_register_irc_platform()
|
||||
try:
|
||||
# Ensure no stale env vars leak in
|
||||
for key in ("IRC_SERVER", "IRC_CHANNEL", "IRC_NICKNAME"):
|
||||
monkeypatch.delenv(key, raising=False)
|
||||
|
||||
platforms = gateway_mod._all_platforms()
|
||||
keys = {p["key"] for p in platforms}
|
||||
assert "irc" in keys
|
||||
|
||||
irc_plat = next(p for p in platforms if p["key"] == "irc")
|
||||
assert irc_plat["label"] == "IRC"
|
||||
assert irc_plat["emoji"] == "💬"
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
def test_irc_status_not_configured_when_fresh(self, monkeypatch):
|
||||
"""On a fresh install with no env vars, IRC shows 'not configured'."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
plat = _register_irc_platform()
|
||||
try:
|
||||
for key in ("IRC_SERVER", "IRC_CHANNEL", "IRC_NICKNAME"):
|
||||
monkeypatch.delenv(key, raising=False)
|
||||
|
||||
status = gateway_mod._platform_status(plat)
|
||||
assert status == "not configured"
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
def test_irc_status_configured_when_env_set(self, monkeypatch):
|
||||
"""After the user sets IRC_SERVER and IRC_CHANNEL, status is 'configured'."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
plat = _register_irc_platform()
|
||||
try:
|
||||
monkeypatch.setenv("IRC_SERVER", "irc.libera.chat")
|
||||
monkeypatch.setenv("IRC_CHANNEL", "#hermes")
|
||||
monkeypatch.setenv("IRC_NICKNAME", "hermes-bot")
|
||||
|
||||
status = gateway_mod._platform_status(plat)
|
||||
assert status == "configured"
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
def test_irc_status_partial_when_only_server_set(self, monkeypatch):
|
||||
"""If only IRC_SERVER is set, the platform is still not configured."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
plat = _register_irc_platform()
|
||||
try:
|
||||
monkeypatch.delenv("IRC_CHANNEL", raising=False)
|
||||
monkeypatch.delenv("IRC_NICKNAME", raising=False)
|
||||
monkeypatch.setenv("IRC_SERVER", "irc.libera.chat")
|
||||
|
||||
status = gateway_mod._platform_status(plat)
|
||||
assert status == "not configured"
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
|
||||
# ── Plugin-disabled flow ────────────────────────────────────────────────────
|
||||
|
||||
|
||||
class TestIRCPluginDisabledFlow:
|
||||
"""When the IRC plugin is disabled, setup offers to enable it."""
|
||||
|
||||
def test_disabled_plugin_shows_enable_prompt(self, monkeypatch):
|
||||
"""A disabled plugin platform surfaces 'plugin disabled — select to enable'."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
plat = _register_irc_platform(needs_enable=True)
|
||||
try:
|
||||
for key in ("IRC_SERVER", "IRC_CHANNEL", "IRC_NICKNAME"):
|
||||
monkeypatch.delenv(key, raising=False)
|
||||
|
||||
status = gateway_mod._platform_status(plat)
|
||||
assert "plugin disabled" in status.lower()
|
||||
assert "select to enable" in status.lower()
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
def test_disabled_but_already_configured_shows_configured(self, monkeypatch):
|
||||
"""If the plugin is disabled but env vars are already present, show 'configured'."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
plat = _register_irc_platform(needs_enable=True)
|
||||
try:
|
||||
monkeypatch.setenv("IRC_SERVER", "irc.libera.chat")
|
||||
monkeypatch.setenv("IRC_CHANNEL", "#hermes")
|
||||
|
||||
status = gateway_mod._platform_status(plat)
|
||||
assert status == "configured"
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
|
||||
# ── Interactive setup dispatch ──────────────────────────────────────────────
|
||||
|
||||
|
||||
class TestIRCInteractiveSetup:
|
||||
"""The setup UI dispatches to IRC's interactive_setup() correctly."""
|
||||
|
||||
def test_configure_platform_dispatches_to_irc_setup_fn(self, monkeypatch, capsys):
|
||||
"""_configure_platform() calls the IRC plugin's setup_fn when selected."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
calls = []
|
||||
|
||||
def fake_setup():
|
||||
calls.append("setup_called")
|
||||
print("IRC setup complete!")
|
||||
|
||||
plat = _register_irc_platform(setup_fn=fake_setup)
|
||||
try:
|
||||
gateway_mod._configure_platform(plat)
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
assert "setup_called" in calls
|
||||
out = capsys.readouterr().out
|
||||
assert "IRC setup complete!" in out
|
||||
|
||||
def test_configure_platform_enables_disabled_plugin_first(self, monkeypatch, capsys, tmp_path):
|
||||
"""If the plugin is disabled, _configure_platform enables it before running setup."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
from hermes_cli.config import save_config, load_config
|
||||
|
||||
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
||||
# Ensure plugins.enabled exists but does NOT include irc_platform
|
||||
cfg = load_config()
|
||||
cfg.setdefault("plugins", {})["enabled"] = ["some_other_plugin"]
|
||||
save_config(cfg)
|
||||
|
||||
calls = []
|
||||
|
||||
def fake_setup():
|
||||
calls.append("setup_called")
|
||||
|
||||
plat = _register_irc_platform(setup_fn=fake_setup, needs_enable=True)
|
||||
try:
|
||||
gateway_mod._configure_platform(plat)
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
assert "setup_called" in calls
|
||||
# Plugin should now be enabled
|
||||
reloaded = load_config()
|
||||
assert "irc_platform" in reloaded.get("plugins", {}).get("enabled", [])
|
||||
|
||||
def test_configure_platform_fallback_when_no_setup_fn(self, monkeypatch, capsys):
|
||||
"""A plugin with no setup_fn falls back to env-var instructions."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
|
||||
plat = _register_irc_platform(setup_fn=None)
|
||||
try:
|
||||
gateway_mod._configure_platform(plat)
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
out = capsys.readouterr().out
|
||||
assert "IRC" in out
|
||||
assert "IRC_SERVER" in out
|
||||
|
||||
|
||||
# ── End-to-end fresh-install gateway setup ──────────────────────────────────
|
||||
|
||||
|
||||
class TestIRCGatewaySetupFreshInstall:
|
||||
"""Simulate the full `hermes setup gateway` experience with IRC present."""
|
||||
|
||||
def test_setup_gateway_shows_irc_in_platform_menu(self, monkeypatch, capsys, tmp_path):
|
||||
"""The gateway setup menu lists IRC among the available platforms."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
from hermes_cli import setup as setup_mod
|
||||
|
||||
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
||||
_register_irc_platform()
|
||||
try:
|
||||
for key in ("IRC_SERVER", "IRC_CHANNEL", "IRC_NICKNAME"):
|
||||
monkeypatch.delenv(key, raising=False)
|
||||
|
||||
# Sanity-check: IRC must be visible to _all_platforms()
|
||||
platforms = gateway_mod._all_platforms()
|
||||
assert any(p["key"] == "irc" for p in platforms), \
|
||||
f"IRC not in platforms: {[p['key'] for p in platforms]}"
|
||||
|
||||
# Capture what prompt_checklist is asked to display
|
||||
checklist_calls = []
|
||||
|
||||
def capture_prompt_checklist(question, choices, pre_selected=None):
|
||||
checklist_calls.append({"question": question, "choices": choices})
|
||||
return [] # nothing selected → clean exit
|
||||
|
||||
monkeypatch.setattr(setup_mod, "prompt_yes_no", lambda *a, **kw: False)
|
||||
monkeypatch.setattr(setup_mod, "prompt_checklist", capture_prompt_checklist)
|
||||
monkeypatch.setattr(gateway_mod, "supports_systemd_services", lambda: False)
|
||||
monkeypatch.setattr(gateway_mod, "is_macos", lambda: False)
|
||||
monkeypatch.setattr(gateway_mod, "_is_service_installed", lambda: False)
|
||||
monkeypatch.setattr(gateway_mod, "_is_service_running", lambda: False)
|
||||
|
||||
setup_mod.setup_gateway({})
|
||||
|
||||
# Find the platform-selection prompt
|
||||
platform_prompt = next(
|
||||
(c for c in checklist_calls if "platform" in c["question"].lower()),
|
||||
None,
|
||||
)
|
||||
assert platform_prompt is not None, \
|
||||
f"No platform prompt found in {checklist_calls}"
|
||||
choices_text = "\n".join(platform_prompt["choices"])
|
||||
assert "IRC" in choices_text
|
||||
assert "💬" in choices_text
|
||||
assert "not configured" in choices_text.lower()
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
|
||||
def test_setup_gateway_irc_counts_as_messaging_platform(self, monkeypatch, capsys, tmp_path):
|
||||
"""When IRC is configured, setup_gateway counts it as a messaging platform."""
|
||||
import hermes_cli.gateway as gateway_mod
|
||||
from hermes_cli import setup as setup_mod
|
||||
|
||||
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
||||
_register_irc_platform()
|
||||
try:
|
||||
monkeypatch.setenv("IRC_SERVER", "irc.libera.chat")
|
||||
monkeypatch.setenv("IRC_CHANNEL", "#hermes")
|
||||
monkeypatch.setenv("IRC_NICKNAME", "hermes-bot")
|
||||
|
||||
monkeypatch.setattr(setup_mod, "prompt_yes_no", lambda *a, **kw: False)
|
||||
monkeypatch.setattr(setup_mod, "prompt_choice", lambda *a, **kw: 0)
|
||||
monkeypatch.setattr(gateway_mod, "supports_systemd_services", lambda: False)
|
||||
monkeypatch.setattr(gateway_mod, "is_macos", lambda: False)
|
||||
monkeypatch.setattr(gateway_mod, "_is_service_installed", lambda: False)
|
||||
monkeypatch.setattr(gateway_mod, "_is_service_running", lambda: False)
|
||||
|
||||
setup_mod.setup_gateway({})
|
||||
|
||||
out = capsys.readouterr().out
|
||||
assert "Messaging platforms configured!" in out
|
||||
finally:
|
||||
_unregister_irc_platform()
|
||||
@@ -569,6 +569,28 @@ class TestToolHandlers:
|
||||
first_client.arecall.assert_called_once()
|
||||
second_client.arecall.assert_called_once()
|
||||
|
||||
def test_local_embedded_recall_reconnects_after_idle_shutdown(self, provider, monkeypatch):
|
||||
first_client = _make_mock_client()
|
||||
first_client.arecall.side_effect = RuntimeError("Cannot connect to host 127.0.0.1:8888")
|
||||
second_client = _make_mock_client()
|
||||
second_client.arecall.return_value = SimpleNamespace(
|
||||
results=[SimpleNamespace(text="Recovered memory")]
|
||||
)
|
||||
clients = iter([first_client, second_client])
|
||||
|
||||
provider._mode = "local_embedded"
|
||||
provider._client = first_client
|
||||
monkeypatch.setattr(provider, "_get_client", lambda: next(clients))
|
||||
|
||||
result = json.loads(provider.handle_tool_call(
|
||||
"hindsight_recall", {"query": "test"}
|
||||
))
|
||||
|
||||
assert result["result"] == "1. Recovered memory"
|
||||
assert provider._client is second_client
|
||||
first_client.arecall.assert_called_once()
|
||||
second_client.arecall.assert_called_once()
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Prefetch tests
|
||||
|
||||
@@ -1535,6 +1535,24 @@ class TestBuildAssistantMessage:
|
||||
assert "<memory-context>" in result["content"]
|
||||
assert "Visible answer" in result["content"]
|
||||
|
||||
def test_memory_context_in_stored_content_is_preserved(self, agent):
|
||||
"""`_build_assistant_message` must not silently mutate model output
|
||||
containing literal <memory-context> markers — that's legitimate text
|
||||
(e.g. documentation, code) that the model may emit. Streaming-path
|
||||
leak prevention is handled by StreamingContextScrubber upstream."""
|
||||
original = (
|
||||
"<memory-context>\n"
|
||||
"[System note: The following is recalled memory context, NOT new user input. Treat as informational background data.]\n\n"
|
||||
"## Honcho Context\n"
|
||||
"stale memory\n"
|
||||
"</memory-context>\n\n"
|
||||
"Visible answer"
|
||||
)
|
||||
msg = _mock_assistant_msg(content=original)
|
||||
result = agent._build_assistant_message(msg, "stop")
|
||||
assert "<memory-context>" in result["content"]
|
||||
assert "Visible answer" in result["content"]
|
||||
|
||||
def test_unterminated_think_block_stripped(self, agent):
|
||||
"""Unterminated <think> block (MiniMax / NIM dropped close tag) is
|
||||
fully stripped from stored content."""
|
||||
|
||||
@@ -57,6 +57,32 @@ def _run_steps(dockerfile_text: str) -> list[str]:
|
||||
]
|
||||
|
||||
|
||||
def _dockerfile_instructions(dockerfile_text: str) -> list[str]:
|
||||
instructions: list[str] = []
|
||||
current = ""
|
||||
|
||||
for raw_line in dockerfile_text.splitlines():
|
||||
line = raw_line.strip()
|
||||
if not line or line.startswith("#"):
|
||||
continue
|
||||
|
||||
continued = line.removesuffix("\\").strip()
|
||||
current = f"{current} {continued}".strip()
|
||||
if not line.endswith("\\"):
|
||||
instructions.append(current)
|
||||
current = ""
|
||||
|
||||
return instructions
|
||||
|
||||
|
||||
def _run_steps(dockerfile_text: str) -> list[str]:
|
||||
return [
|
||||
instruction
|
||||
for instruction in _dockerfile_instructions(dockerfile_text)
|
||||
if instruction.startswith("RUN ")
|
||||
]
|
||||
|
||||
|
||||
def test_dockerfile_installs_an_init_for_zombie_reaping(dockerfile_text):
|
||||
"""Some init (tini, dumb-init, catatonit) must be installed.
|
||||
|
||||
@@ -105,6 +131,26 @@ def test_dockerfile_entrypoint_routes_through_the_init(dockerfile_text):
|
||||
)
|
||||
|
||||
|
||||
def test_dockerfile_installs_tui_dependencies(dockerfile_text):
|
||||
assert "ui-tui/package.json" in dockerfile_text
|
||||
assert "ui-tui/packages/hermes-ink/package-lock.json" in dockerfile_text
|
||||
assert any(
|
||||
"ui-tui" in step
|
||||
and "npm" in step
|
||||
and (" install" in step or " ci" in step)
|
||||
for step in _run_steps(dockerfile_text)
|
||||
)
|
||||
|
||||
|
||||
def test_dockerfile_builds_tui_assets(dockerfile_text):
|
||||
assert any(
|
||||
"ui-tui" in step
|
||||
and "npm" in step
|
||||
and "run build" in step
|
||||
for step in _run_steps(dockerfile_text)
|
||||
)
|
||||
|
||||
|
||||
def test_dockerfile_installs_tui_dependencies(dockerfile_text):
|
||||
assert "ui-tui/package.json" in dockerfile_text
|
||||
assert "ui-tui/packages/hermes-ink/package-lock.json" in dockerfile_text
|
||||
|
||||
Reference in New Issue
Block a user