Support browser CDP URL from config
This commit is contained in:
@@ -184,6 +184,8 @@ _HERMES_BEHAVIORAL_VARS = frozenset({
|
||||
"HERMES_BACKGROUND_NOTIFICATIONS",
|
||||
"HERMES_EXEC_ASK",
|
||||
"HERMES_HOME_MODE",
|
||||
"BROWSER_CDP_URL",
|
||||
"CAMOFOX_URL",
|
||||
})
|
||||
|
||||
|
||||
|
||||
@@ -77,3 +77,42 @@ class TestResolveCdpOverride:
|
||||
"https://cdp.browser-use.example/session/json/version",
|
||||
timeout=10,
|
||||
)
|
||||
|
||||
|
||||
class TestGetCdpOverride:
|
||||
def test_prefers_env_var_over_config(self, monkeypatch):
|
||||
import tools.browser_tool as browser_tool
|
||||
|
||||
monkeypatch.setenv("BROWSER_CDP_URL", HTTP_URL)
|
||||
monkeypatch.setattr(
|
||||
browser_tool,
|
||||
"read_raw_config",
|
||||
lambda: {"browser": {"cdp_url": "http://config-host:9222"}},
|
||||
raising=False,
|
||||
)
|
||||
|
||||
response = Mock()
|
||||
response.raise_for_status.return_value = None
|
||||
response.json.return_value = {"webSocketDebuggerUrl": WS_URL}
|
||||
|
||||
with patch("tools.browser_tool.requests.get", return_value=response) as mock_get:
|
||||
resolved = browser_tool._get_cdp_override()
|
||||
|
||||
assert resolved == WS_URL
|
||||
mock_get.assert_called_once_with(VERSION_URL, timeout=10)
|
||||
|
||||
def test_uses_config_browser_cdp_url_when_env_missing(self, monkeypatch):
|
||||
import tools.browser_tool as browser_tool
|
||||
|
||||
monkeypatch.delenv("BROWSER_CDP_URL", raising=False)
|
||||
|
||||
response = Mock()
|
||||
response.raise_for_status.return_value = None
|
||||
response.json.return_value = {"webSocketDebuggerUrl": WS_URL}
|
||||
|
||||
with patch("hermes_cli.config.read_raw_config", return_value={"browser": {"cdp_url": HTTP_URL}}), \
|
||||
patch("tools.browser_tool.requests.get", return_value=response) as mock_get:
|
||||
resolved = browser_tool._get_cdp_override()
|
||||
|
||||
assert resolved == WS_URL
|
||||
mock_get.assert_called_once_with(VERSION_URL, timeout=10)
|
||||
|
||||
Reference in New Issue
Block a user