common/hermes
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(cli): prevent temp directory leak on ZIP update failure

Browse Source 
Move shutil.rmtree into a finally block so the temp directory is always
cleaned up, even when an exception occurs during download, extraction,
or file copying.
This commit is contained in:
0xchainer
2026-05-23 22:26:49 +03:00
committed by Teknium
parent 3b096d6f6d
commit 2c34a7da87
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
hermes_cli/main.py
View File

@@ -6932,8 +6932,8 @@ def _update_via_zip(args):
) )
print("→ Downloading latest version...") print("→ Downloading latest version...")
tmp_dir = tempfile.mkdtemp(prefix="hermes-update-")
try: try:
tmp_dir = tempfile.mkdtemp(prefix="hermes-update-")
zip_path = os.path.join(tmp_dir, f"hermes-agent-{branch}.zip") zip_path = os.path.join(tmp_dir, f"hermes-agent-{branch}.zip")
urlretrieve(zip_url, zip_path) urlretrieve(zip_url, zip_path)
@@ -6980,12 +6980,11 @@ def _update_via_zip(args):
print(f"✓ Updated {update_count} items from ZIP") print(f"✓ Updated {update_count} items from ZIP")
# Cleanup
shutil.rmtree(tmp_dir, ignore_errors=True)
except Exception as e: except Exception as e:
print(f"✗ ZIP update failed: {e}") print(f"✗ ZIP update failed: {e}")
sys.exit(1) sys.exit(1)
finally:
shutil.rmtree(tmp_dir, ignore_errors=True)
# Clear stale bytecode after ZIP extraction # Clear stale bytecode after ZIP extraction
removed = _clear_bytecode_cache(PROJECT_ROOT) removed = _clear_bytecode_cache(PROJECT_ROOT)