From 258755a24fa37225edd39890f9411ba4d8752353 Mon Sep 17 00:00:00 2001
From: teknium1 <127238744+teknium1@users.noreply.github.com>
Date: Wed, 29 Apr 2026 05:01:58 -0700
Subject: [PATCH] test(weixin): cover _is_stale_session_ret helper (#17228)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Regression test for the ret=-2 / errmsg='unknown error' disambiguation:
- ret=-2 or errcode=-2 with 'unknown error' → stale session (True)
- ret=-2 with 'freq limit' or other errmsg → rate limit (False)
- ret=-14 → not matched here (handled by SESSION_EXPIRED_ERRCODE path)
- Success codes and missing errmsg → False
---
 tests/gateway/test_weixin.py | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tests/gateway/test_weixin.py b/tests/gateway/test_weixin.py
index 3a377effb..506936f71 100644
--- a/tests/gateway/test_weixin.py
+++ b/tests/gateway/test_weixin.py
@@ -758,3 +758,33 @@ class TestWeixinVoiceSending:
         assert voice_item["encode_type"] == 6
         assert voice_item["sample_rate"] == 24000
         assert voice_item["bits_per_sample"] == 16
+
+
+class TestIsStaleSessionRet:
+    """Regression test for #17228: distinguish stale-session ret=-2 from rate-limit ret=-2."""
+
+    def test_ret_minus_2_with_unknown_error_is_stale(self):
+        assert weixin._is_stale_session_ret(-2, None, "unknown error") is True
+
+    def test_errcode_minus_2_with_unknown_error_is_stale(self):
+        assert weixin._is_stale_session_ret(None, -2, "unknown error") is True
+
+    def test_unknown_error_case_insensitive(self):
+        assert weixin._is_stale_session_ret(-2, None, "Unknown Error") is True
+
+    def test_ret_minus_2_with_freq_limit_is_not_stale(self):
+        # Genuine rate limit — must NOT be treated as stale session.
+        assert weixin._is_stale_session_ret(-2, None, "freq limit") is False
+
+    def test_ret_minus_2_with_no_errmsg_is_not_stale(self):
+        assert weixin._is_stale_session_ret(-2, None, None) is False
+        assert weixin._is_stale_session_ret(-2, None, "") is False
+
+    def test_errcode_minus_14_is_not_matched_here(self):
+        # -14 is handled by the separate SESSION_EXPIRED_ERRCODE path; the
+        # helper only disambiguates -2 from a genuine rate limit.
+        assert weixin._is_stale_session_ret(-14, None, "session expired") is False
+
+    def test_success_codes_are_not_stale(self):
+        assert weixin._is_stale_session_ret(0, 0, "") is False
+        assert weixin._is_stale_session_ret(None, None, "unknown error") is False